Neos-ui: Date incorrectly selected in datepicker

[gerhard-boden]

Description

Selected date is wrong (+1 day) in the datepicker when property format is set to DateTime without setting any fomat.
When setting

          editorOptions:
            format: 'd-m-Y H:i'

it still works

Steps to Reproduce

Expected behavior

Correct date to be selected

Actual behavior

Wrong date is selected

Affected Versions

Neos: 4.1.8

UI: 3.3.0

[dimaip]

Probably it has something to do with timezones, right?

[gerhard-boden]

Most likely, maybe even the recent day light savings adjustment. Can also take a look, but will take a couple of days until i can make the time

[maya-shines]

Currently looking into this. It definitely is a timezone/day light savings issue.
I set the Hide Before value to 22-05-2019 00:00 and in the database, it stores the hiddenbeforedatetime as 2019-05-21 22:00:00

[markusguenther]

@maya-shines Friendly status check :)
Still on it or ready for another one?

[Nikdro]

*push
Is there a solution in sight? Or is the exact problem identified?
More and more customers are getting annoyed by this bug...

[markusguenther]

@maya-shines I know that you started working on that. But don't know your status.
Would offer to pick that issue tomorrow, when you don't have the resources at the moment to tackle this.

[maya-shines]

Hey, gosh, I'm so sorry, this slipped right past me!
I looked into it but got all kinds of tangled up in it. There is practically no status. @markusguenther, have at it, if you have the time. And feel free to reach out to me (on slack or wherever). Maybe the stuff I did find out might help you get on the right track.

[markusguenther]

Thanks @maya-shines, if you have some investigations. Feel free to write it down. Otherwise will tackle that.

[grizooo]

I could reproduced that behaivior. If the Server timezone was changed from UTC to, for example: "Europe/Berlin" this problem exists. If you have selected UTC as timzone you would have no problem.

The Dates will be saved with timzone information wich was set to server. The frontend datepicker does not accept other timzones than UTC so the dates will be shown incorrectly.

The timzone will be ignored if you add time information into the property so it seems to work correct.

Workaround will be

1. add Time Information to date properties like:
   format: 'd-m-Y H:i'

or

1. Change server timezone to UTC and write a node migration to convert all existing dates as UTC in the database

... should be fixed soon

[gerhard-boden]

I took a look at this tonight and I think I'm on to something. Thanks for all the provided feedback, hopefully I can set up a PR this week which will fix the issue, without introducing new date related issues.

[gerhard-boden]

Caught a cold last week, but the fix is finally here:
https://github.com/neos/neos-ui/pull/2558

Pretty easy in the end, but was a bit hard to reproduce, since it does not occur on fresh installations where persisted time defaults to 02:00 (CEST)