Neos-ui: Fire events to notify the guest frame of changes made in the UI

Created on 6 Jul 2017  Â·  6Comments  Â·  Source: neos/neos-ui

We should fire the same events as in the Ember UI (on node creation, node removal etc.) as documented here:

http://neos.readthedocs.io/en/stable/ExtendingNeos/InteractionWithTheNeosBackend.html#javascript-events

Some events are obsolete due to the iframe solution. These would be imho:

  • Neos.PageLoaded
  • Neos.PreviewModeActivated
  • Neos.PreviewModeDeactivated
  • Neos.LayoutChanged
  • Neos.NavigatePanelOpened
  • Neos.NavigatePanelClosed
  • Neos.InspectorPanelOpened
  • Neos.InspectorPanelClosed
  • Neos.EditPreviewPanelOpened
  • Neos.EditPreviewPanelClosed
  • Neos.MenuPanelOpened
  • Neos.MenuPanelClosed
  • Neos.FullScreenModeActivated
  • Neos.FullScreenModeDeactivated

All of these would now be eual to DOMContentLoaded in the guest frame. But maybe we should fire them anyway to make it possible to distinguish between the different states they represent?

Good first issue Frontend / Frontend-API

Most helpful comment

Not all of them makes sense. But Neos.NodeCreated, Neos.NodeRemoved and Neos.NodeSelected would be very useful and important

All 6 comments

I'd suggest if we have a website which makes use of these events, we can check whether we really need them (and which ones)

Not all of them makes sense. But Neos.NodeCreated, Neos.NodeRemoved and Neos.NodeSelected would be very useful and important

I need that in a current project. Especially I need to know when a content node is inserted into the DOM and I need to know the nodeType in the eventlistener.

If someone can implement this in the near future (next 3 weeks), I can offer some donation from my project budget. Currently I could give like 500 € for that.

I had this on my todo list, but the tricky part is figuring out what events are really needed.
E.g. currently all of these things are already possible via our extensibillity API (by registering a custom Saga and listening for the right kind of Redux actions).
@DrillSergeant maybe we could have a call about what things you would want to achieve and what would be the best way to do it?

@dimaip yeah nice. We already chatted on slack about this. I would love to explain my need during a call. Just contact me on slack to find a date for it.

@dimaip I think @grebaldi has there a good opinion: His list of events who are obsolete looks very good to me. At the end, there are this events left:

  • Neos.NodeCreated
  • Neos.NodeRemoved
  • Neos.NodeSelected

The only I would recommend to have from the obsolete list is Neos.FullScreenModeActivated and Neos.FullScreenModeDeactivated, because sometimes you want to use it as a "fast preview"

Was this page helpful?
0 / 5 - 0 ratings

Related issues

johannessteu picture johannessteu  Â·  4Comments

DrillSergeant picture DrillSergeant  Â·  9Comments

jonnitto picture jonnitto  Â·  7Comments

dimaip picture dimaip  Â·  10Comments

dennisirmscher picture dennisirmscher  Â·  7Comments