Neon-wallet: Allow configurable block due limit to expire pending transactions

[igormcoelho]

It would be nice to have support to due time in transaction created on neon wallet! This issue was discussed here (https://github.com/neo-project/neo/issues/371), and would prevent transactions to "stay forever" on relay nodes if network is overloaded. For now, the idea is just to discuss the idea, but I can help to implement it, on future free times :)

Wallet version or commit SHA:
e.g.: 0.2.3 or dcae88c

Environment:
e.g.: Win 10 Home (64 bit) Version 1709 Build 16299.309

Prerequisites:
e.g.: Don't have any custom tokens added before running the wallet

Reproduction steps:
e.g.:

1. Start Neon Wallet
2. Click on "Manage Neon settings" button
3. Click on "Manage Tokens" button
4. Click on "Add a new token" button

some description (for ex. what happens after completing reproduction steps), e.g.:
After clicking on "Add a new token" button, wallet "hangs" for 2 seconds.

Screenshots/Video:
e.g.: https://example.com/screenshot.png

[comountainclimber]

How exactly do you propose implementing this in the electron app? Sounds like a feature we would implement (if we could) in neon-js

[igormcoelho]

That's exactly the plan @comountainclimber , I plan to help snowy to implement this in neon-js soon enough. It's already tested on neocompiler.io. What we would need in the app is to create a configuration box to setup how many blocks ahead will be used as default (or even disable this feature perhaps). Do you think that's possible? The regular user won't ever notice that there is an implicit limit, but the timeout message must need to be changed, from time (in seconds), to a block count... if transaction is not confirmed in any of the following blocks, then a message is displayed that it has failed (we will need to implemented that too in neon-js!! this noticed that...)

[comountainclimber]

Ahh makes mroe sense now... We could easily account for this in the new settings UI with a default to whatever makes the most sense. It would be fairly straight forward in that regard 👍

[igormcoelho]

I forgot to ask one thing... do you use neon-js, right? Or is it another js api? I don't know any of neon-wallet code :)

[drptbl]

@igormcoelho Yes, Neon Wallet is using neon-js.

[igormcoelho]

Ok, I will start to work on this feature soon enough, based on neon-js version v4, as v3 will only accept bugfixes now.

[comountainclimber]

@igormcoelho any update on this? I would really like to get this in as part of a revamp of the neon-wallet tx UI/UX and think it would be a very valuable addition

[igormcoelho]

Still struggling to port our software to neon-js v4 hahaha not many changes, but I need to understand them well to propose this. I believe this week is a reasonable deadline for this. Congratulations for this amazing wallet remake! :)