Neon-wallet: Disable ability to spam "Refresh" buttons on wallet dashboard

Created on 28 Apr 2018  路  7Comments  路  Source: CityOfZion/neon-wallet

Wallet version or commit SHA:
ef95d25

Environment:
Win 10 Home (64 bit) Version 1709 Build 16299.371

Prerequisites:
At least one wallet imported to the app

Reproduction steps:

  1. Start Neon Wallet
  2. Click on "Login using a saved wallet" button
  3. Select your wallet, enter your passphrase and click on "Login" button
  4. Click on "Refresh" button several times in a row

Currently user is able to spam "Refresh" buttons causing requests to queue. "Refresh" buttons shouldn't be able to be clicked until requests have finished loading.

Screenshots/Video:
ref_but_spam

Bug

All 7 comments

should be a trivial fix I can take care of it 馃憤

Code complete, just pending QA.

@comountainclimber After re-testing - this issue is still valid.

Changes from linked PR (#1023) applies only to AssetBalancesPanel.jsx, but TokenBalancesPanel.jsx has been forgotten. Because of that this issue is still valid for "Refresh" button in "Token Balances" section (it's spammable).

Also it would be nice to mention that "Retry?" buttons shouldn't be spammable too (maybe they need additional coding):
retry1

I wasn't able to test these changes on "Refresh" button in "Balances" section because it's broken currently (#1079). Will re-test later, after it's fixed.

Wallet version: 0f2951a

@drptbl good call... I can address all of the above

Fixed by #1159, pending QA.

Looks good, thanks!

Was this page helpful?
0 / 5 - 0 ratings