Neo: NullReferenceException when createAccount using scriptHash

[eryeer]

I came across an Exception when testing CreateAccount(UInt160 scriptHash) in Neo.Wallets.SQLite.UserWallet.

CreateAccount(UInt160 scriptHash) will call AddAccount(UserWalletAccount account, bool is_import) method but line126 Address db_address = ctx.Addresses.FirstOrDefault(p => p.ScriptHash == account.Contract.ScriptHash.ToArray()); in Neo.Wallets.SQLite.UserWallet will throw a NullReferenceException because account.Contract is null.

I think we need to add a nullable check before line126 .

[shargon]

Could you share with me this Unit test file?

[eryeer]

Please take a look at TestCreateAccountByScriptHash method in this file UT_UserWallet.cs

[Tommo-L]

https://github.com/eryeer/neoUT/blob/ut_bug/neo.UnitTests/Wallets/SQLite/UT_UserWallet.cs#L102-L107

[shargon]

Take a look at this pr:

https://github.com/eryeer/neoUT/pull/10

[eryeer]

Nick work @shargon ! Now I can close this.