Nativescript-plugin-firebase: Validation for analytics event key seems incorrect

Created on 27 Aug 2019  路  1Comment  路  Source: EddyVerbruggen/nativescript-plugin-firebase

According to the comment in analytics-common.ts and also official document: https://firebase.google.com/docs/reference/cpp/group/parameter-names, alphanumeric characters are allowed in param names.

However, the regexp used in the following line does not accept 'numeric' character.

https://github.com/EddyVerbruggen/nativescript-plugin-firebase/blob/6a2e0a9f1aeb26f6e568c3e68bd960069f4fe150/src/analytics/analytics-common.ts#L12

So, a param name like 'group1' is rejected by the logic.

Android Analytics bug iOS

Most helpful comment

Damn, you're right. Let me fix that. Thanks for reporting it!

>All comments

Damn, you're right. Let me fix that. Thanks for reporting it!

Was this page helpful?
0 / 5 - 0 ratings