Nativefier: Alt+Shift keyboard shortcut causes menu bar to appear

[revengel]

Description

If keyboard layout switched by Alt+Shift - window main menu is appearing.

Steps to Reproduce Issue

1. Open nativefier application (i.e. Twitter)
2. Click "new Tweet"
3. Press "Alt+Shift"
4. See that the main menu is appeared.
   

   Specifications

• Version of Nativefier (run $ nativefier --version): v6.10.1
• Version of Node.js (run $ node --version): v5.9.0
• OS: Linux - archlinux
• Architecture amd64

[jiahaog]

Sorry for the late reply! Could you try updating and using the latest version of nativefier?

[revengel]

Hello. Do I must to remove my applications and create them again?

[jiahaog]

You have to replace them again if you want them to be built with the latest version of nativefier. However, you can test if the same issue occurs by creating an app just to test it out

[revengel]

I have installed nativefier via

npm install nativefier -g

and recreate application by following command

nativefier -n Twitterr -o -i twitter.png --width 500 --height 850 -u
"Mozilla/5.0 (iPad; CPU OS 9_1 like Mac OS X) AppleWebKit/601.1.46 (KHTML,
like Gecko) Version/9.0 Mobile/13B143 Safari/601.1" --counter -d Twitter
https://mobile.twitter.com/

problem still exists

[joeytwiddle]

Here on Ubuntu but running Fluxbox, the app's menu appears and disappears whenever I press Alt on its own.

It looks like Electron has an option for this: autoHideMenuBar. I tried added that option to ~/.config/<app_name>/window-state.json with value false, on the offchance, but it had no effect.

[joeytwiddle]

I'm guessing this is Linux specific.

The menu is actually toggling every time I Alt-Tab to switch off or back onto the app!

It looks like this small patch attempted to disable the menu bar entirely. But it didn't work for me.

What did work:

• After the app is built, edit [app_folder]/resources/app/lib/main.js
• Search for the line function createMenu(_ref) {
• Add return; on the line below it.

```
function createMenu(_ref) {
return;

  var nativefierVersion = _ref.nativefierVersion;
  ...

```

Note however that doing this will disable some keybinds, such as Ctrl + / - for zooming.

[ronjouch]

@joeytwiddle @revengel is this bug still valid? Here under Linux (Arch/GNOME) the menubar behaves well: Alt+Shift doesn't reveal it, Alt+Tab doesn't either, only pressing only Alt reveals it. That might have changed in recent Electrons, can you try with a recent one? (I just tried nativefier -e 1.6.6 "https://google.com").

Closing, please come back if the bug is still present!

[joeytwiddle]

My issue with Alt and Alt-Tab and Ctrl-Alt-Arrow (switch desktops) toggling the menubar has gone away.

Now I have a constant menu bar which doesn't toggle. That removes the annoyance. :+1:

I see there is also a compile-time option: --disable-context-menu

It might be nice in future to have another one: --disable-menubar for those who don't want it.

[ronjouch]

@joeytwiddle this option exists, and defaults to hiding the menu bar:

~ nativefier --help | grep menu-bar
    -m, --show-menu-bar             set menu bar visible, defaults to false

Can you try fiddling with it on the latest nativefier? Here it works, if it doesn't for you it's a bug, then please come back with all the info you can get (nativefier version, node version, os, full nativefier command used).

[itziksha]

Hi,
I have an issue on windows.
I don't want to see the nenu bar, but pressing alt, shows it.
The only way to avoid showing the menu bar is using the --hide-window-frame, but I need the frame.
I tried --show-menu-bar false but it doesn't work.

Any suggestion?
Thanks.

[ronjouch]

"I don't want to see the nenu bar, but pressing alt, shows it."

@itziks00 hi, thanks for the feedback! That's upstream Electron behavior we AFAIK have no control on (I might be wrong, then please point to APIs supporting changing the behavior). Please search for / file a bug at electron.

---

EDIT reading discussion at https://github.com/jiahaog/nativefier/pull/58#issuecomment-306137450 from @itziks00, there might be a way to tell Electron not to show the menu on Alt.

[itziksha]

Thanks @ronjouch .
As you mentioned, at https://github.com/jiahaog/nativefier/pull/58 this solution works but it's just a workaround and requires to change it manually every build.

[zsinba]

how to hide the menu ?