Name-suggestion-index: Support some sub-country regions (e.g. Canadian Province, US State)

[lionirdeadman]

Currently in Canada, Quebec vs English Canada entries are used when they are the same entity because of name=*, I think they could be all made into one if the NSI could determine which name it should use based on the location's language.

I don't know how possible that is but that would be nice.

[bhousel]

Thanks for raising this - are there some brands where we get this wrong?

I'm not familiar with the local expectation here, but my guess is that adding both name:en and name:fr tags might be enough.

For some entries we already do add multiple language tags where multiple local languages are commonly spoken (e.g. things in Belarus commonly use both Russian and Belarusian)

[bhousel]

I took care of National Bank of Canada, but if you find any more please open an issue and I'll take care of it 👍

[lionirdeadman]

The problem with choosing name=* as only english or another language is that name=* is supposed to represent what's on the ground, the localized name, at least that's been my understanding of it.

And for the examples of National Bank and Desjardins is that in Quebec unlike the rest of Canada, French is always used exclusively or 10% bigger than the english name as per Bill 101.

So making them both as the same entry without making the NSI know which localization should be used for name=*, it creates huge inaccuraties as the NSI is used more and more..

[bhousel]

Ok well, let me know what to do. I'm totally ok with combining them into a single entry, or having 2 and people can choose. I thought you wanted me to combine them.

We don't currently have a way to scope a brand to anything smaller than the country level, but it's something we're thinking about.

[lionirdeadman]

Well, this issue was to have the ability to have them in one but respect localization beyond on a country-level but since this is something you're already thinking about, I guess it's fair to close this issue and put them back as two different entries and let people choose until it's possible to combine them in a way which respects localization beyond the country-level.

Where can I track the issue on scoping things smaller than the country level?

Thanks and sorry for the quite late response ^^'

[bhousel]

Where can I track the issue on scoping things smaller than the country level?

Let's leave this issue open for it..

[bkissin]

One thing I've run into working on Quebec tags is that Staples in Quebec is Bureau en Gros

Additionally, some communities that are really into Bill 101 will have KFC listed as PFK (Poulet Frit Kentucky). I've been tagging them as the regular source but then renaming the feature to fit the local environment.

[bhousel]

I started a thing today that I hope will make it easy to define complex regions, since this has become thing I want for several projects.
https://github.com/ideditor/location-conflation

[bhousel]

I started a thing today that I hope will make it easy to define complex regions, since this has become thing I want for several projects.
https://github.com/ideditor/location-conflation

☝️ FYI, I'm planning to do this in the next few days. This approach has worked pretty well in the osm-community-index and imagery-index projects.

This is why I'm trying to clear out all the outstanding PRs. This change will affect how we store countryCodes and will be breaking across all the files.

[Adamant36]

I'm going to close this now that it's implemented. 👍 on the new way of doing it.

[bhousel]

But I didnt actually do the thing the issue is about yet

[Adamant36]

My bad. I thought you did.

[bhousel]

Hey @lionirdeadman I'd like to close this issue now that we have the ability to limit a brand to a sub-country region. Is it correct to say that these brands should be in French only in Quebec?

[lionirdeadman]

That is correct, name=* should be French-only in Quebec. (I assume name:en=* remains unchanged)

[bhousel]

@lionirdeadman - can you check that last commit c7373e4 ?
I split the national bank brand back into 2 entries:

• "National Bank" for all of Canada except Quebec
• "Banque Nationale" for just Quebec

Does this approach look alright? If so, we can do this for the other brands you and @bkissin mentioned.

[lionirdeadman]

That seems good. I'm not familiar with how the code works but it seems right to me. Although, I thought the ideal model would've simply had the nsi pick name:en or name:fr based on geolocation rather than keeping them duplicated?