The way that JS is versioned inside templates at the minute is to manually update the version ?ver=XYZ in templates. This is error-prone and time consuming.
Frostschutz suggested instead adding something like ?ver={$mybb->version_code} (example name), with the version code being automatically updated on upgrade: https://community.mybb.com/thread-214063-post-1288791.html#pid1288791
This would save quite a lot of effort for developers of the core and theme authors (see the rest of the above linked thread for more details).
euantorano
All 7 comments
+1 馃懟(the ghost is my +1)
irlcatgirl
on 15 Nov 2017
Agreed.
WildcardSearch
on 16 Nov 2017
How about a one time hash that is generated on each install/upgrade? That way there is no disclosure of the version number in the source code. Needless to say that this would be a great improvement regardless.
JordanMussi
on 16 Nov 2017
A one time hash sounds like a good plan. Easiest version would be the install/upgrade timestamp which shouldn't be too sensitive.
euantorano
on 16 Nov 2017
A tool for bumping the timestamp could also come in handy.
dvz
on 16 Nov 2017
This is going to be a good thing.
WildcardSearch
on 17 Nov 2017
The straight forward approach, imho is to detect the last modified timestamp of the file and use that stamp for versioning. filemtime() may come handy for this.
Also we should version the css files same way. We already are capturing the 'lastmodified' stamp in database which we can use for css versioning.
effone
on 7 Apr 2018
Related issues
Ben-MyBB
路
5Comments
Ben-MyBB
路
7Comments
Ben-MyBB
路
4Comments
LogicPlague
路
5Comments
woostarUK
路
4Comments
Most helpful comment
A tool for bumping the timestamp could also come in handy.