Mumble: Add Windows 10 visual elements manifest

[ElPumpo]

https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/appxmanifestschema/element-visualelements
We'd need a white background that would blend in with the logo

[ElPumpo]

https://pastebin.com/td8J7YqK VS2017, filename.visualelementsmanifest.xml

[ElPumpo]

https://pastebin.com/PNh4F4PM

Kinda works with the "new" logo, but there is a thin black circle around

[ElPumpo]

#FFFFFF also works

[Tarun80]

Personally, I think the previous one looks better.

[ElPumpo]

Yea, I'm not a fan of the full white color, tried to remove the black circle, but noticed that it was a faded color from top to bottom. Let the art guys do a correct image

[Kissaki]

That’s only for store apps?

[ElPumpo]

@Kissaki no, it's when you pin a exe on the start menu (Windows 10)

[ElPumpo]

Any updates on this?

[davidebeatrici]

How does the tile look like without the visual manifest?

[ElPumpo]

Looks like this. The first image (on top) is without the manifest file, and the image below is with the manifest added.

The manifest must be placed in the same directory as the executable is found, and the first characters before the dot . must match the executable name.
mumble.visualelementsmanifest.xml

<Application xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
 <VisualElements
BackgroundColor="#FFFFFF"
ShowNameOnSquare150x150Logo="on"
ForegroundText="dark"/>
</Application>

[ElPumpo]

Closing this issue as it seems abandoned

[Krzmbrzl]

@ElPumpo why haven't you created a PR? To me it seems as if you know what had to be changed? :thinking:

[ElPumpo]

Yes sorry I've been busy with other projects. If you're interested I'll for sure propose a pull request.

[Krzmbrzl]

No need to be sorry :)

Sure looks useful to me. Wouldn't it be better to use a logo with transparent background in this case instead of turning the background white? That way I think it'd better blend in with the other icons, wouldn't it?

[ElPumpo]

To be honest I'm not sure I know how you would like it to look like

[Krzmbrzl]

In the Screenshot you showed all other icons are blue whereas Mumble is white

[ElPumpo]

Yes they are blue because that's what my windows theme thing is set to, I'll look into a transparent background

[Krzmbrzl]

Yeah then I think it'd be nice if Mumble's icon was blue as well.
However if having the white background is certainly better than what it is like right now. So if you think that you don't want to spend more time on this (at the moment), feel free to create a PR for that already. If we find a solution to make it transparent we can always patch that in later on :)

PS: I'll reopen this issue for now

[ElPumpo]

For your information the documentation for this can be found over at https://docs.microsoft.com/en-us/uwp/schemas/appxpackage/appxmanifestschema/element-visualelements I'll get a pr ready

[ElPumpo]

You know what.. I have no clue where in the project to put this file

[Krzmbrzl]

You know what.. I have no clue where in the project to put this file

You said it has to be installed into the same directory as the Mumble executable, right? In that case the file should be placed in the ' installer' directory in this project and we/I have to figure out how to use WiX to install this file as well :point_up:

[Krzmbrzl]

I might have an idea on how this could be done, but I'm far from sure. I never really touched the installer code.

@trudnorx recently changed the installer and appeared very competent at doing so. Any chance you (@trudnorx) could point us in the right direction here?
Or maybe @davidebeatrici knows what has to be done :point_up:

[streaps]

I don't understand why it needs a white background?

[Krzmbrzl]

In order to not look like https://user-images.githubusercontent.com/12564301/50525936-fcb13480-0ade-11e9-974c-377506ad1847.png

[streaps]

Isn't it possible to use the round Mumble icon with a transparent background?
https://github.com/mumble-voip/mumble/blob/master/icons/mumble.svg

The one in the screenshot looks like it has some aliasing / scaling issues.

[ElPumpo]

Transparent backgrounds aren't possible

[Krzmbrzl]

Transparent backgrounds aren't possible

But if that is the case how does the virtual box entry work that is located to the left of the Mumble icon in your screenshot? Are they just using the same background color by accident?

[Krzmbrzl]

@zeroability found https://docs.microsoft.com/en-us/visualstudio/extensibility/ux-guidelines/images-and-icons-for-visual-studio?view=vs-2019

According to that Windows should actually support alpha channels which would then allow for a transparent background. The question is: What kind of icon are we currently using? :thinking:

[ZeroAbility]

@ZeroAbility found https://docs.microsoft.com/en-us/visualstudio/extensibility/ux-guidelines/images-and-icons-for-visual-studio?view=vs-2019

For context:
"32-bit ICO: for Project icons and Add Item. All ICO files are 32-bit true color with alpha-channel transparency (RGB/A). Because ICO files can store multiple sizes and color depths, Vista icons are often in an ICO format containing 16x16, 32x32, 48x48, and 256x256 image sizes. In order to display properly in Windows Explorer, ICO files must be saved-down to 24-bit and 8-bit color depths for each image size."

The cpack created installer in the new cmake build system uses the ico file.
https://github.com/davidebeatrici/mumble/blob/481db81f87835d2fcc1a3591979df38ee9fea405/cmake/packaging.cmake#L19