Mumble: Settings window should be non-modal, and the "Apply" button should apply settings immediately

[Nuc1eoN]

Hi I am on the latest v1.3 snapshot (64bit) and it appears that the apply button does not work as it should.

Simple steps to reproduce:

1. Open Preferences
2. Go to User Interface and change the "layout"
3. Press apply

The new layout will not be applied until restart.
However pressing "OK" works as it should and applies the setting correctly.

[mkrautz]

Changing the UI layout should be applied after you close the Settings dialog.

The reason is that the Settings dialog is modal. So we can't really change the main window while Settings is shown.

[mkrautz]

Does that work for you?

[Nuc1eoN]

Hm not really. Do the following:

1. Open settings
2. Change skin, language, layout or comparable preferences
3. Press Apply
4. Press Cancel

Now the settings window has closed but your settings have not (literally) been "applied". The apply button is there exatly for this reason to apply settings immediatly.
Actually I have never seen a similar logic in other applications.

The simplest example is Windows: Change your resolution and press Apply, it will happen immediately. Actually I have never really seen an Application doing it the "mumble way".

EDIT: Better comparison: Teamspeak. In their settings "Apply" changes settings immediatly. However their Settings window is not modal..

[mkrautz]

Turned this into a feature request.

I agree that it would make more sense if we:

1. Made Settings non-modal. This is necessary for this behavior, I believe.
2. We'd need a weak pointer to hold the reference to the settings window, such that two windows won't be open at the same time.
3. Clicking apply should trigger the behavior that currently happens after the ConfigDialog's exec() ends. However, that behavior should also trigger when the window is destroyed -- but not if it has already been triggered by clicking apply.

[Nuc1eoN]

Although it's kinda a different bug, #1364 goes in the same direction of settings being applied immediatly.
Looks like it's been a mindset of the first mumble devs^^