Mremoteng: SQL Error with the latest Dev Branch

Created on 30 Jun 2020  路  4Comments  路  Source: mRemoteNG/mRemoteNG

Useing the latest Dev Branch gives the following SQL error

Can't save connection file as ""!
The DataColumn Favorite for the SourceColumn Favorite is missing.

Version 1.77.1.30726

All 4 comments

I ran into this exact problem.
At a glance, this works. It is a hack, not my fault if more is broken than fixed.

in sqldataprovider.cs line 54

change select * to select ID, ConstantID, PositionID, ParentID, LastChange, Name, Type, Expanded, AutomaticResize, CacheBitmaps, Colors, ConnectToConsole, Connected, Description, DisableCursorBlinking, DisableCursorShadow, DisableFullWindowDrag, DisableMenuAnimations, DisplayThemes, DisplayWallpaper, Domain, EnableDesktopComposition, EnableFontSmoothing, ExtApp, Favorite, Hostname, ICAEncryptionStrength, Icon, LoadBalanceInfo, MacAddress, Panel, Password, Port, PostExtApp, PreExtApp, Protocol, PuttySession, RDGatewayDomain, RDGatewayHostname, RDGatewayPassword, RDGatewayUsageMethod, RDGatewayUseConnectionCredentials, RDGatewayUsername, RDPAlertIdleTimeout, RDPAuthenticationLevel, RDPMinutesToIdleTimeout, RdpVersion, RedirectAudioCapture, RedirectClipboard, RedirectDiskDrives, RedirectKeys, RedirectPorts, RedirectPrinters, RedirectSmartCards, RedirectSound, RenderingEngine, Resolution, SSHOptions, SSHTunnelConnectionName, SoundQuality, UseCredSsp, UseEnhancedMode, UseVmId, UserField, Username, VNCAuthMode, VNCColors, VNCCompression, VNCEncoding, VNCProxyIP, VNCProxyPassword, VNCProxyPort, VNCProxyType, VNCProxyUsername, VNCSmartSizeMode, VNCViewOnly, VmId, InheritAutomaticResize, InheritCacheBitmaps, InheritColors, InheritDescription, InheritDisableCursorBlinking, InheritDisableCursorShadow, InheritDisableFullWindowDrag, InheritDisableMenuAnimations, InheritDisplayThemes, InheritDisplayWallpaper, InheritDomain, InheritEnableDesktopComposition, InheritEnableFontSmoothing, InheritExtApp, InheritFavorite, InheritICAEncryptionStrength, InheritIcon, InheritLoadBalanceInfo, InheritMacAddress, InheritPanel, InheritPassword, InheritPort, InheritPostExtApp, InheritPreExtApp, InheritProtocol, InheritPuttySession, InheritRDGatewayDomain, InheritRDGatewayHostname, InheritRDGatewayPassword, InheritRDGatewayUsageMethod, InheritRDGatewayUseConnectionCredentials, InheritRDGatewayUsername, InheritRDPAlertIdleTimeout, InheritRDPAuthenticationLevel, InheritRDPMinutesToIdleTimeout, InheritRdpVersion, InheritRedirectAudioCapture, InheritRedirectClipboard, InheritRedirectDiskDrives, InheritRedirectKeys, InheritRedirectPorts, InheritRedirectPrinters, InheritRedirectSmartCards, InheritRedirectSound, InheritRenderingEngine, InheritResolution, InheritSSHOptions, InheritSSHTunnelConnectionName, InheritSoundQuality, InheritUseConsoleSession, InheritUseCredSsp, InheritUseEnhancedMode, InheritUseVmId, InheritUserField, InheritUsername, InheritVNCAuthMode, InheritVNCColors, InheritVNCCompression, InheritVNCEncoding, InheritVNCProxyIP, InheritVNCProxyPassword, InheritVNCProxyPort, InheritVNCProxyType, InheritVNCProxyUsername, InheritVNCSmartSizeMode, InheritVNCViewOnly, InheritVmId

re-create MSSQL DB, allowing for nulls in a few places that I suspect are newly defunct(ica) or misconfigured(favorites)

if exists (select * from dbo.sysobjects 
    where id = object_id(N'[dbo].[tblCons]') and OBJECTPROPERTY(id, N'IsUserTable') = 1)
drop table [dbo].[tblCons]
GO

if exists (select * from dbo.sysobjects 
    where id = object_id(N'[dbo].[tblRoot]') and OBJECTPROPERTY(id, N'IsUserTable') = 1)
drop table [dbo].[tblRoot]
GO

if exists (select * from dbo.sysobjects 
    where id = object_id(N'[dbo].[tblUpdate]') and OBJECTPROPERTY(id, N'IsUserTable') = 1)
drop table [dbo].[tblUpdate]
GO

CREATE TABLE [dbo].[tblCons] (
    [ID] int NOT NULL IDENTITY(1,1),
    [ConstantID] varchar(128) NOT NULL PRIMARY KEY,
    [PositionID] int NOT NULL,
    [ParentID] varchar(128),
    [LastChange] datetime NOT NULL,
    [Name] varchar(128) NOT NULL,
    [Type] varchar(32) NOT NULL,
    [Expanded] bit NOT NULL,
    [AutomaticResize] bit DEFAULT ((1)) NOT NULL,
    [CacheBitmaps] bit NOT NULL,
    [Colors] varchar(32) NOT NULL,
    [ConnectToConsole] bit NOT NULL,
    [Connected] bit NOT NULL,
    [Description] varchar(1024),
    [DisableCursorBlinking] bit NOT NULL,
    [DisableCursorShadow] bit NOT NULL,
    [DisableFullWindowDrag] bit NOT NULL,
    [DisableMenuAnimations] bit NOT NULL,
    [DisplayThemes] bit NOT NULL,
    [DisplayWallpaper] bit NOT NULL,
    [Domain] varchar(512),
    [EnableDesktopComposition] bit NOT NULL,
    [EnableFontSmoothing] bit NOT NULL,
    [ExtApp] varchar(256),
    [Favorite] tinyint,                      --modified to allow nulls
    [Hostname] varchar(512),
    [ICAEncryptionStrength] varchar(32),     --modified to allow nulls
    [Icon] varchar(128) NOT NULL,
    [LoadBalanceInfo] varchar(1024),
    [MacAddress] varchar(32),
    [Panel] varchar(128) NOT NULL,
    [Password] varchar(1024),
    [Port] int NOT NULL,
    [PostExtApp] varchar(256),
    [PreExtApp] varchar(256),
    [Protocol] varchar(32) NOT NULL,
    [PuttySession] varchar(128),
    [RDGatewayDomain] varchar(512),
    [RDGatewayHostname] varchar(512),
    [RDGatewayPassword] varchar(1024),
    [RDGatewayUsageMethod] varchar(32) NOT NULL,
    [RDGatewayUseConnectionCredentials] varchar(32) NOT NULL,
    [RDGatewayUsername] varchar(512),
    [RDPAlertIdleTimeout] bit NOT NULL,
    [RDPAuthenticationLevel] varchar(32) NOT NULL,
    [RDPMinutesToIdleTimeout] int NOT NULL,
    [RdpVersion] varchar(10),
    [RedirectAudioCapture] bit NOT NULL,
    [RedirectClipboard] bit DEFAULT ((0)) NOT NULL,
    [RedirectDiskDrives] bit NOT NULL,
    [RedirectKeys] bit NOT NULL,
    [RedirectPorts] bit NOT NULL,
    [RedirectPrinters] bit NOT NULL,
    [RedirectSmartCards] bit NOT NULL,
    [RedirectSound] varchar(64) NOT NULL,
    [RenderingEngine] varchar(10),
    [Resolution] varchar(32) NOT NULL,
    [SSHOptions] varchar(1024) NOT NULL,
    [SSHTunnelConnectionName] varchar(128) NOT NULL,
    [SoundQuality] varchar(20) NOT NULL,
    [UseCredSsp] bit NOT NULL,
    [UseEnhancedMode] bit DEFAULT ((0)),
    [UseVmId] bit,
    [UserField] varchar(256),
    [Username] varchar(512),
    [VNCAuthMode] varchar(10),
    [VNCColors] varchar(10),
    [VNCCompression] varchar(10),
    [VNCEncoding] varchar(20),
    [VNCProxyIP] varchar(128),
    [VNCProxyPassword] varchar(1024),
    [VNCProxyPort] int,
    [VNCProxyType] varchar(20),
    [VNCProxyUsername] varchar(512),
    [VNCSmartSizeMode] varchar(20),
    [VNCViewOnly] bit NOT NULL,
    [VmId] varchar(100),
    [InheritAutomaticResize] bit DEFAULT ((0)) NOT NULL,
    [InheritCacheBitmaps] bit NOT NULL,
    [InheritColors] bit NOT NULL,
    [InheritDescription] bit NOT NULL,
    [InheritDisableCursorBlinking] bit NOT NULL,
    [InheritDisableCursorShadow] bit NOT NULL,
    [InheritDisableFullWindowDrag] bit NOT NULL,
    [InheritDisableMenuAnimations] bit NOT NULL,
    [InheritDisplayThemes] bit NOT NULL,
    [InheritDisplayWallpaper] bit NOT NULL,
    [InheritDomain] bit NOT NULL,
    [InheritEnableDesktopComposition] bit NOT NULL,
    [InheritEnableFontSmoothing] bit NOT NULL,
    [InheritExtApp] bit NOT NULL,
    [InheritFavorite] bit,                --modified to allow nulls
    [InheritICAEncryptionStrength] bit,   --modified to allow nulls
    [InheritIcon] bit NOT NULL,
    [InheritLoadBalanceInfo] bit DEFAULT ((0)) NOT NULL,
    [InheritMacAddress] bit NOT NULL,
    [InheritPanel] bit NOT NULL,
    [InheritPassword] bit NOT NULL,
    [InheritPort] bit NOT NULL,
    [InheritPostExtApp] bit NOT NULL,
    [InheritPreExtApp] bit NOT NULL,
    [InheritProtocol] bit NOT NULL,
    [InheritPuttySession] bit NOT NULL,
    [InheritRDGatewayDomain] bit NOT NULL,
    [InheritRDGatewayHostname] bit NOT NULL,
    [InheritRDGatewayPassword] bit NOT NULL,
    [InheritRDGatewayUsageMethod] bit NOT NULL,
    [InheritRDGatewayUseConnectionCredentials] bit NOT NULL,
    [InheritRDGatewayUsername] bit NOT NULL,
    [InheritRDPAlertIdleTimeout] bit NOT NULL,
    [InheritRDPAuthenticationLevel] bit NOT NULL,
    [InheritRDPMinutesToIdleTimeout] bit NOT NULL,
    [InheritRdpVersion] bit DEFAULT ((0)) NOT NULL,
    [InheritRedirectAudioCapture] bit NOT NULL,
    [InheritRedirectClipboard] bit DEFAULT ((0)) NOT NULL,
    [InheritRedirectDiskDrives] bit NOT NULL,
    [InheritRedirectKeys] bit NOT NULL,
    [InheritRedirectPorts] bit NOT NULL,
    [InheritRedirectPrinters] bit NOT NULL,
    [InheritRedirectSmartCards] bit NOT NULL,
    [InheritRedirectSound] bit NOT NULL,
    [InheritRenderingEngine] bit NOT NULL,
    [InheritResolution] bit NOT NULL,
    [InheritSSHOptions] bit NOT NULL,
    [InheritSSHTunnelConnectionName] bit NOT NULL,
    [InheritSoundQuality] bit NOT NULL,
    [InheritUseConsoleSession] bit NOT NULL,
    [InheritUseCredSsp] bit NOT NULL,
    [InheritUseEnhancedMode] bit DEFAULT ((0)),
    [InheritUseVmId] bit,
    [InheritUserField] bit NOT NULL,
    [InheritUsername] bit NOT NULL,
    [InheritVNCAuthMode] bit NOT NULL,
    [InheritVNCColors] bit NOT NULL,
    [InheritVNCCompression] bit NOT NULL,
    [InheritVNCEncoding] bit NOT NULL,
    [InheritVNCProxyIP] bit NOT NULL,
    [InheritVNCProxyPassword] bit NOT NULL,
    [InheritVNCProxyPort] bit NOT NULL,
    [InheritVNCProxyType] bit NOT NULL,
    [InheritVNCProxyUsername] bit NOT NULL,
    [InheritVNCSmartSizeMode] bit NOT NULL,
    [InheritVNCViewOnly] bit NOT NULL,
    [InheritVmId] bit   
) ON [PRIMARY] 
GO

CREATE TABLE [dbo].[tblRoot] (
    [Name] [varchar] (2048) NOT NULL ,
    [Export] [bit] NOT NULL ,
    [Protected] [varchar] (4048) NOT NULL ,
    [ConfVersion] [float] NOT NULL 
) ON [PRIMARY]
GO

CREATE TABLE [dbo].[tblUpdate] (
    [LastUpdate] [datetime] NULL 
) ON [PRIMARY]
GO


For MySQL, change these tables when creating the table

Favorite tinyint(1),
ICAEncryptionStrength varchar(32),
InheritFavorite tinyint(1),
InheritICAEncryptionStrength tinyint(1),

For MySQL, change these tables when creating the table

Favorite tinyint(1),
ICAEncryptionStrength varchar(32),
InheritFavorite tinyint(1),
InheritICAEncryptionStrength tinyint(1),

Still the same issue after doing this

For MySQL, change these tables when creating the table
Favorite tinyint(1),
ICAEncryptionStrength varchar(32),
InheritFavorite tinyint(1),
InheritICAEncryptionStrength tinyint(1),

Still the same issue after doing this

I guess you also need to hack here: "in sqldataprovider.cs line 54" as wrote before
My question also: how can we implement this into a new/downloadable version...

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sparerd picture sparerd  路  3Comments

seth-c-stenzel picture seth-c-stenzel  路  4Comments

luke-weller picture luke-weller  路  4Comments

mmcnay picture mmcnay  路  4Comments

mattbob-brock picture mattbob-brock  路  3Comments