Moveit: 2018 Summer: release indigo

Created on 25 Jul 2018 · 19Comments · Source: ros-planning/moveit

TODO
Steps to do to make this release happen:

[x] Move full_pr2 pkgs to moveit_pr2 repo -> done https://github.com/ros-planning/moveit_pr2/pull/98
[x] Resolve circular dependency -> PR https://github.com/ros-planning/moveit/pull/1111
[x] Update rosdistro indigo about the moveit_full_pr2 relocation (currently its in moveit section). -> PR made https://github.com/ros/rosdistro/pull/19343
- While this can be done either by making release of moveit indigo, cleanest is to open a PR to rosdistro to just update the location and nothing else. Once that's done, nothing further shouldn't be neeed regarding moveit_full_pr2 location (no version update for moveit_full_pr2 so no new release shouldn't be needed, unless we want to weave in the information about relocation explicitly in the release info).
[x] moveit_pr2: package versions are not aligned b/w moveit_full_pr2 (that is 0.7.14 while the rest is 0.6.6).
[x] Release moveit_pr2 -> delegated at https://github.com/ros-planning/moveit_pr2/issues/100
[x] Make Indigo release from moveit repo.

We want to have another indigo release to distribute the last few bugfixes in the indigo-devel branch.

Unless users request other patches in indigo, this might very well be the last release for this ROS distribution.
We stopped cherry-picking back to indigo for quite a while now
and with some effort the kinetic-devel branch can be compiled and used on Ubuntu 14.04 too.

I will run the ABI checks and report back until the end of the week.

Source

v4hn

Most helpful comment

Nice, issue #1000.

gavanderhoorn on 25 Jul 2018

🎉3

All 19 comments

Nice, issue #1000.

gavanderhoorn on 25 Jul 2018

🎉3

@130s

The only ABI-incompatible changes I found are https://github.com/ros-planning/moveit/pull/443
@davetcoleman removed the alternative time parameterization method again, because it was supposed to be replaced by the better alternative.
However, the new alternative was not merged into indigo-devel anymore.

I believe it is ok to release the branch as is. Alternatively, we could backport the newer spline parameterization method to provide another alternative for indigo.

v4hn on 1 Aug 2018

Ah I hadn't realized the newer time parameterization plugin was kinetic only. I think it makes sense to cherry-pick back to indigo, but it also probably doesn't matter much since its a new barely used feature that doesn't belong in an old LTS

davetcoleman on 1 Aug 2018

Does releasing Kinetic and/or Melodic together make sense, or does that need a separate discussion?

130s on 1 Aug 2018

Does releasing Kinetic and/or Melodic together make sense, or does that need a separate discussion?

To be honest I don't know right now.

Given that GSoC will end soon I lean towards having the next release kinetic+ after the results get merged.

v4hn on 6 Aug 2018

I see.

I'm planning to make release on this weekend, for Indigo only.

130s on 15 Aug 2018

I agree with @v4hn on waiting another week or so.

The MSA isn't in the ideal state right now because our GSoC student @MohmadAyman had three different features in different PRs, and I tested them individually locally (built them), but when they were merged together there were some unexpected regressions

davetcoleman on 15 Aug 2018

Can anyone list the ticket numbers that need to be addressed before Indigo release?

130s on 31 Aug 2018

Can anyone list the ticket numbers that need to be addressed before Indigo release?

None to the best of my knowledge.

v4hn on 31 Aug 2018

Ah, then I might have misunderstood the few previous posts like https://github.com/ros-planning/moveit/issues/1000#issuecomment-413307231. So now my understanding: indigo release is ready (and it has been...turned out I've just slacked off from it. I thought there were blockers). I'll get to it this weekend.

130s on 1 Sep 2018

@130s I believe #1000 (comment) has been addressed in pull request #1022 .

But a failing unittest on ROS build server appeared, it didn't fail on Travis that is why we didn't notice earlier, issue #1034 , and pull request #1042 should solve it, the PR needs approvals to be merged.