Moveit: `catkin_lint` packages

[v4hn]

In an initial attempt (e.g. https://github.com/ros-planning/moveit_core/pull/305) I ran catkin_lint on moveit_core, geometric_shapes and some other repos and cleaned up many issues spotted by the linter.

Many of MoveIt's ROS-packages still produce a number of errors.
This is your chance to change that and prevent future problems with broken dependencies, broken CMakeLists constructs, issues to port packages from OSRF's /opt/ folder to /usr, etc. :-)

A few issues reported by catkin_lint are false-positives or explicit decisions by the maintainers.

The most famous one is:

moveit_core: CMakeLists.txt(6): error: variable CMAKE_BUILD_TYPE is modified

It was decided that MoveIt should default to "Release" build type for maximum performance, so this is no error.
~Bonus points if you find a way to make catkin_lint stop complaining about it.~ (This has been fixed in catkin_lint)

As this touches a number of different packages, please do not assign to this ticket.
Instead, find yourself a moveit package catkin_lint complains about, add a note saying you are looking into this package and submit one pull-request for each package you clean.

[davetcoleman]

linting the entire code base would allow us to then create a continuous integration test to capture bugs like: https://github.com/ros-planning/moveit_ci/issues/11

[corot]

:+1: I'm also interested on making catkin_lint stop complaining about overwritten CMAKE_BUILD_TYPE

[mintar]

@corot : catkin_lint --ignore immutable_var suppresses the error about CMAKE_BUILD_TYPE (but perhaps also others?).

If you call catkin_lint --explain, it will give a short explanation of each error / warning and tell you how to ignore it.

[corot]

Very useful; viel danke! :clap:

[roehling]

Bonus points if you find a way to make catkin_lint stop complaining about it.

I changed the catkin_lint logic (as of version 1.4.14) so it won't complain any more if the set() command occurs inside an if() that checks for NOT CMAKE_BUILD_TYPE, so I'm helping myself to a few bonus points: .....

[v4hn]

Nice, one more step towards a catkin_lint-compliant MoveIt!
@roehling Give me a call when you want to cash your points ;)

[dhled]

I'm working on it !
Moveit_commander done
Moveit_setup_assistant done
Moveit_ros_planning done
Moveit_kinematics next

[davetcoleman]

It appears some of these have already been done. Given our effort to port to moveit2, I will close this and we can focus on cleaning up ament instead.