Moneymanagerex: User theme incorrect folder issue

[vomikan]

In case if not 100% complited theme file placed into 'res' folder mmex crash.

3105

[whalley]

Messing about with any files in the 'res' folder - adding, modifying, deleting may cause adverse behavior - it is not just the themes. I don't see why this is a bug. The resource folder is part of the application and should not be modified.

[whalley]

What I would suggest is that we make ALL themes need ALL icons and I can add a check to ensure all icons are present, and report error if any are missing. If somebody wants to create a new theme they would either need to base it on another .mmextheme file or create from new. That way it is clear.

If it inherits files from another theme then it runs the risk of 'breaking the look-n-feel' if that other theme changes. So I suggest a theme is self contained.

[vomikan]

I suggest to use default theme for all icons on initialization process.
Then overwrite all icons that would be find in other themes.

PS I understand that this is not a bug per se, but we need to protect the program from smart users.
PSS The option to have the theme contain all the icons I like less. On other hand, in that case it's better store theme on github repository. The readme.md file would represent all icons.

[whalley]

I think we will have disagree on this for now :-)

Whilst I understand your point of avoiding the user missing an icon in a theme by using the default icon set it then means, as I noted above, that the you can no longer guarantee that the user theme will always look the same - the 'default' we use may change over time. I.e. it can break the look-n-fell of the user theme.

If I implement a check to make sure that all necessary icons/files are include in the user theme then it will alert the user to the fact that some are missing and the theme is not compatible with the current application version. This will allow us to also alert users that the theme is out-of-date if new icons or other theme files are added in a new release. Having it silently load the 'defaults' would hide this from the user.

This way we protect the user from creating invalid themes and can make sure it will always display the same no matter what changes in the default.

[vomikan]

This will be a good solution. Fewer compromises - higher reliability.

[vomikan]

Thanks to the readme.md file, you can define the appearance and completeness of the data.

https://github.com/moneymanagerex/Art/tree/master/themes/yellow-blue

So I support the idea of checking the topic for compliance.

[whalley]

Now checks that all icon files exist and can be converted and also that the master.css file is present. If not, the user is warned and the default theme adopted until the issues are fixed.

[whalley]

@vomikan Thanks for the tidy-up. We good to close this now?