Modules: Backporting regression fix from master to 9.x

Created on 6 Mar 2018  路  3Comments  路  Source: nodejs/modules

Hey All,

we have an open PR to backport a change to modules from master to 9.x

https://github.com/nodejs/node/pull/18923

Are there objections to landing this? As it had been landed on master prior to us deciding that we wanted to discuss a code freeze, I think it makes sense to backport.

discussion

Most helpful comment

Are there objections to landing this? As it had been landed on master prior to us deciding that we wanted to discuss a code freeze, I think it makes sense to backport.

In general, I think that:

  • The consensus is against a code freeze at the moment, while we agreed that the current implementation might break in incompatible ways.
  • We should default to the current status, as we're not a chartered working group - even if we wanted to object to landing something we should likely do so in the "regular" TSC approved way (in the PR)

All 3 comments

I don't see this as controversial.
That said, bugs in something experimental are nothing new so I don't see backporting as a must either.

Are there objections to landing this? As it had been landed on master prior to us deciding that we wanted to discuss a code freeze, I think it makes sense to backport.

In general, I think that:

  • The consensus is against a code freeze at the moment, while we agreed that the current implementation might break in incompatible ways.
  • We should default to the current status, as we're not a chartered working group - even if we wanted to object to landing something we should likely do so in the "regular" TSC approved way (in the PR)

Thanks for chiming in folks. I landed the backport. We can discuss further in the meeting next week

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MylesBorins picture MylesBorins  路  4Comments

GeoffreyBooth picture GeoffreyBooth  路  5Comments

MylesBorins picture MylesBorins  路  4Comments

vejja picture vejja  路  5Comments

WebReflection picture WebReflection  路  5Comments