Mobile: Windows 10 Support

[spawn-guy]

Well, this whole thing is written in C# and Xamarin...

Why is there no W10/M version of this app? an UWP app maybe?

[kspearrin]

There are plans to add support for a UWP add. Shouldn't bee too much work to add.

[amoraitis]

Please assign this to me! I want to begin building Xamarin.UWP for this project @kspearrin

[kspearrin]

@amoraitis Feel free to add a UWP project to the solution. This is Xamarin.Forms so the majority of the work should already be done.

[amoraitis]

@kspearrin Ok, i added a UWP project in src/! I want guidelines. I must add it in test/ first and commit changes there?

[kspearrin]

If you need some help with getting started I am always available for chat in our gitter channel: https://gitter.im/bitwarden/Lobby

[TotallyInformation]

+1 for this, especially as your website claims that it is for "all" devices. At the moment it clearly isn't.

[amoraitis]

Ok, to any dev: if you want to finish UWP project contribute to this forked repo:https://github.com/amoraitis/mobile and i will reopen the pull request here, once the project finish!

[Soneliem]

Any advancements on the Window 10 app? @amoraitis your github link does not work BTW.

[kspearrin]

@Soneliem No, unfortunately we have not made any progress here yet.

[Soneliem]

@kspearrin Sad to hear that. A windows app would be really useful.

[alistair23]

@amoraitis fork is down. How far did this end up getting?

[kspearrin]

@alistair23 As far as I know, nowhere.

[hichamboushaba]

Hello, I forked the repo, and added the necessary services to get the app running in Windows 10, we can continue working on the app on my fork until it's ready to make a pull request: https://github.com/hichamboushaba/bitwarden-mobile

Many services are still unimplemented, and the application needs a little theming, feel free to contribute, and me too I will try to implement the missing parts on my free time.

@kspearrin, I have some remarks/questions concerning the project:
1- you don't plan to migrate from PCL to Netstandard? this will give a boarded API which will help in more code sharing, I can help in this if you are interested
2- I had to add extensions to all image names in the PCL project, without them Forms doesn't resolve them for UWP. you are OK with this? AFAIK it doesn't impact other platforms (https://developer.xamarin.com/guides/xamarin-forms/user-interface/images/#Local_Images)
3- when do you plan to update forms nuget to v2.4?, it has a lot of fixes for UWP

Below some screenshots for the application in Windows:

[kspearrin]

@hichamboushaba That looks great so far! I glanced at your commits in your repo and it looks like you're definitely on the right track to get this working fully.

Your questions:

1. I'd like to and have attempted this a few times already but ran into several bugs, particularly around resource files for languages not working. Last time I tried was in VS 15.3 about 1-2 months ago. Maybe the tooling is fixed now with 15.4 preview (which I am using now).
2. I am fine with that as long as it doesn't affect other platforms. I can't think of any issues at the moment.
3. Looks like 2.4 went live yesterday. I'm fine with updating to it. Not sure what breaking changes it may have though.

[hichamboushaba]

@kspearrin, thanks, I will try to add the missing parts before making pull request

About the first point, I'm using Netstandard (csproj) for a personal project, and yes, the issue with resx files is fixed now.

And about 2.4, I was using the pre-release in a production application for more than month now, and I didn't have any issues more than the stable ones 😄 , but there is some small breaking changes like changing adding the RuntimePlatform name for UWP instead of Windows...

[kspearrin]

@hichamboushaba Let's try to do this in phases. I'd like to keep the PRs as small as possible. So if you can avoid net standard and 2.4 for now, we can do that in another PR.

[hichamboushaba]

@kspearrin, yes of course :)
If you prefer I can even make a PR for what's done so far to keep it small.

[kspearrin]

If what you have compiles and runs that is good enough for a PR.

[alistair23]

I tested this over the weekend and it works on my Windows 10 Phone and Windows 10 computer. Are you planning on submitting the app to the Microsoft store soon?

[kspearrin]

It needs a lot of UI work before we can submit it.

[alistair23]

Ok, if you have specific areas in mind I can try and help.

[kspearrin]

Feel free to message me in our developer chatroom and I can go over a few things with you: https://gitter.im/bitwarden/Lobby

[alistair23]

Ok, so here are some main things that I see that still need to be done (in order of priority):

• [ ] Maintain list position when backing out of vault editing
• [ ] Fix Ctrl+a, tab and enter when logging in on Windows 10
• [ ] Fix the vertical height being wrong with login and register pages. I think this needs a custom renderer, but I couldn't get it working even with that.
• [ ] Add U2F FIDO support
• [x] Add Yubikey support
• [x] Get ListView fixed -> Next Xamarin Forms version: https://github.com/xamarin/Xamarin.Forms/issues/1439
• [x] Change "Log In" button to an arrow
• [x] Rename the fingerprint option to Windows Hello
• [x] Fix the camera not coming up when doing a QR scan
• [x] Fix the Group vault not being displayed, all the others are it's just this one
• [x] Fix the loading bar to go across the entire screen
• [x] Improve the toast notifcation colours
• [x] Fix images to use correct size/scaling on UWP

[alistair23]

I have forked the code base and have a bitwarden client available on the Windows store, if anyone is interested: https://www.microsoft.com/en-us/store/p/bytewarden/9n248v7dk05k

[kspearrin]

This is no longer planned for this mobile. We not have official desktop apps. @alistair23 's port can be used if people are interested.