Mithril.js: Run danger against PRs

[tivac]

I would like to implement http://danger.systems/ for mithril PRs.

They've got a nodejs version that I implemented against modular-css as an experiment, it's nice.

Here's my current list of ideas for checks:

• 🛑 PR targeting master instead of next
• 🛑 lint failures (since they don't fail the build)
• 🛑 o.only in a test
• ⚠️ Request a change-log.md entry for .js file changes
• ⚠️ Request a descriptor of the semver change required for the PR to land (if .js files changed)

Any other ideas? Anyone vehemently against this proposal?

[pygy]

I'm vehemently for this proposal

[isiahmeadows]

I like this proposal a lot myself. I'll note that the "use strict" requirement is already mandated by the ESLint settings, so making DangerCI check it is redundant.

[tivac]

@isiahmeadows fair, edited. I think the danger-style output is a lot nicer to read than eslint results though. Especially since lint failures don't fail the build.

yet.