Mithril.js: Bundle isn't strict?

Created on 4 Jul 2018  路  4Comments  路  Source: MithrilJS/mithril.js

The latest bundle is not in strict mode. I thought this had been addressed previously...?

Workflow Bug
Source
picture isiahmeadows

All 4 comments

Hi @isiahmeadows!

Good catch, it looks like a closure compiler thing, that only happens in the minified build.

pygy picture pygy on 5 Jul 2018
😕1 😄1

So maybe replace it with a dev dependency of uglify-js? (It's cheap to install in CI - it has zero dependencies.)

isiahmeadows picture isiahmeadows on 6 Jul 2018

BTW, UglifyJS generally compresses better than Closure Compiler for unannotated code, so it might not be a bad idea to switch either way.

isiahmeadows picture isiahmeadows on 6 Jul 2018

This appears fixed in the latest bundle.

isiahmeadows picture isiahmeadows on 29 Oct 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

dhinesh03 picture dhinesh03  路  4Comments
mke21 picture mke21  路  3Comments
volnei picture volnei  路  3Comments
barneycarroll picture barneycarroll  路  3Comments
raykyri picture raykyri  路  4Comments