Misskey: Image order gets scrambled when federating

[chocological00]

💡 Summary

When posting a note with manually ordered images, the activitypub renderer reorder images to uploaded order.

🙂 Expected Behavior

Images should be federated in the order set in Misskey.

☹️ Actual Behavior

Images get federated in DB row order.

📝 Steps to Reproduce

On local the image is ordered fine, but on remote the image order is scrambled.

📌 Environment

Misskey 11.34.0 -> Other ActivityPub instances (including other Misskey Instance)

[chocological00]

Temporary fix here, but maybe there is a way to order this in ORM instead of using .sort()?

[mei23]

Related to (or duplicated?) https://github.com/syuilo/misskey/issues/5550

[mei23]

By Misskey's drive feature, sometimes DB order vs attached order is different.
So you need to preserve the attached order, instead of sorting by the id (DB row order / uploaded order).