Minetest_game: If you die while using an item you don't lose the item

[raymoo]

If you die as part of the processing of an item use, the item doesn't get removed and put in bones.
Unsure whether this is a minetest or minetest_game problem, but since bones is supposed to implement "losing items", I'm putting this here.

[ghost]

How to replicate: 1. /giveme flowers:mushroom_red 99, 2. Eat a bunch of them. You will die, and respawn, all without losing the itemstack.

I ran into this and sidestepped the issue here: https://github.com/jastevenson303/runfast/commit/53cce77b960b1fc057fcf1c764d31415151a721c#diff-d7d74284e2e39f6c06d199c8e2bedbd0L348 with a minetest.after :/

[raymoo]

note: Bones puts it in the bones node anyway, which would make this a duplication exploit (though only limited to items that you can kill yourself with).

[rubenwardy]

The HP should be check during the server step instead, when no Lua functions are running. This ~probably~ hopefully won't break any mods.

[tenplus1]

Couldnt we just take this line and place it right before the "return itemstack" so it takes item before causing any food harm ? https://github.com/minetest/minetest/blob/604fe2083d70fea92b6c53c9a9d1c1ffdcb36610/builtin/game/item.lua#L454

[raymoo]

@tenplus1 No, that won't work. The problem isn't that processing gets interrupted, it's that the user dies during processing (and so death processing happens, and the player gets their item put in bones), and after processing is finished the returned itemstack is given to the player even though they lost the original stack.

[tenplus1]

so would a minetest.after() function not help to finish process before doing damage ?

[raymoo]

It would, as @jastevenson303 already mentioned. It's a hack though.

[tenplus1]

only other way i can think is in the actual on_use function for the red shroom itself, eat 1st, damage after.

[ghost]

if hp > 0 then return itemstack
else return ""

?

[raymoo]

@jastevenson303 If the server doesn't have bones activated then they shouldn't lose items.

[ghost]

if hp > 0 then return itemstack
elseif minetest.settings:get("bones_mode") ~= "keep" then return ""

?

Ps. I think if one were to do this to red mushrooms, they'd find many other food items they'd need to modify also. I wonder now about minetest.item_eat(), if the issue can be resolved there.

[rubenwardy]

This should not be fixed in mods, but by the engine or builtin

[paramat]

Engine issue https://github.com/minetest/minetest/issues/6546

[InfiniteOtter]

The extra red mushrooms grew on your corpse. You ate them and that inoculated you with the spores. There, order has been preserved.

[tenplus1]

lol infinite

[ghost]

This too: https://github.com/minetest/minetest_game/issues/1900 (for completeness)