Minetest_game: Cactus seedling

[Extex101]

In the current version of Minetest, the Cactus naturally grows in the shape of

Where as grown cactus looks like this:

So there is no way to re-create the original look
So I think there should be a cactus seedling!


### /\ SUBJECT TO CHANGE /\
raw file

[TumeniNodes]

Cacti can grow from seeds or cuttings.

I do believe the current method, references using a cutting.

Hoping not to sound rude, I am not crazy about using 'cactus_sapling' (if it were 'cactus_seedling' I could be more sold but I honestly do not see an issue with the current set up)

[ghost]

I believe the issue is the inconsistency.

[TumeniNodes]

I think that needs to be addressed in the schematic, I'll take a look at it.

Full grown cactus should look as originals which are placed by mapgen.

[TumeniNodes]

Adding a new table for cactus_seedling would probably be best.

Using the image provided here would work nice as cactus_seedling but, then the seedling needs to have a schematic.
I can do this (hopefully shortly)

[paramat]

Good point. If this is done i would add a 'sapling' for 'large cactus' and have it behave like a tree.

Tumeni, the cactus seedlng would just be a plantlike node, we don't need a new schematic.
What do you mean by 'I think that needs to be addressed in the schematic,'?

[TumeniNodes]

if you want to add a cactus_sapling that's fine but it needs to be added as a schematic does it not? Same as trees do.
That is what I mean, the cactus will need a cactus_from_sapling.mts

I still feel 'sapling' is the wrong word to use for this instance, and should be 'seedling' https://duckduckgo.com/?q=cactus+seedlings&t=lm&iax=images&ia=images
because they are _not_ the same as trees

[paramat]

the cactus will need a cactus_from_sapling.mts

Yes, i see what you're saying now. But the seedling itself will not be a schematic as you have written.
And yeah sapling is the wrong word.

[Extex101]

OK yeah I looked up what they where called but I couldn't find anything which is why I wrote sapling
+Changed

[TumeniNodes]

is this not what would be needed?

```
-- Large cactus

local C = {name = "default:cactus", prob = 255, param2 = 20}
local R = {name = "default:cactus", prob = 255, param2 = 20, force_place = true}
local E = {name = "default:cactus", prob = 127, param2 = 20}

mts_save("large_cactus", {
size = {x = 5, y = 7, z = 1},
data = {
_, _, R, _, _,
_, _, C, _, _,
_, _, C, _, _,
C, C, C, C, C,
C, _, C, _, C,
E, _, C, _, E,
_, _, C, _, _,
},
})

-- Large cactus from seedling

local C = {name = "default:cactus", prob = 255, param2 = 20}
local R = {name = "default:cactus", prob = 255, param2 = 20, force_place = true}
local E = {name = "default:cactus", prob = 127, param2 = 20}

mts_save("large_cactus_from_seedling", {
size = {x = 5, y = 7, z = 1},
data = {
_, _, R, _, _,
_, _, C, _, _,
_, _, C, _, _,
C, C, C, C, C,
C, _, C, _, C,
E, _, C, _, E,
_, _, C, _, _,
},
})

[paramat]

But those schematics are identical :)

Actually, i've just seen that the cactus schematic only force-places the node in the ground, so we don't need a second schematic.
However in order to replace the seedling, the 2nd node up in the 'trunk' now needs to be force-placed too.

[paramat]

Anyway, this is a good valid issue, the large cactus has been a little sloppy. I support making it growable using a special 'large cactus seedling'.

[paramat]

A seedling should be expensive in a recipe, so that you only get 1 or 2 from a large cactus, so i would make the recipe:

CCC
_C_

[Extex101]

Okay sounds good

[TumeniNodes]

But those schematics are identical :)

Actually, i've just seen that the cactus schematic only force-places the node in the ground, so we don't need a second schematic.
However in order to replace the seedling, the 2nd node up in the 'trunk' now needs to be force-placed too.

Oh good, I can scrap what I was poking with then :D
@Extex101 are you going to make a PR for this?

[Extex101]

I can't atm I won't have access to a computer for a few days

[TumeniNodes]

That's ok, it can wait :)

[paramat]

I like the cactus seedling texture in the first post, Extex101 i assume you made it?

[Extex101]

Yup I made it, although it's based off of the original cactus texture

[Extex101]

OK so i'm gonna make a PR but i'm not sure how..
Also i don't know how to make it work like a sapling (grow)

[TumeniNodes]

paramat explained what is needed here https://github.com/minetest/minetest_game/issues/2255#issuecomment-434151816

I can do this PR if you like... if you plan to do it yourself

the new schematic needs to look like so

```
-- Large cactus

local C = {name = "default:cactus", prob = 255, param2 = 20}
local R = {name = "default:cactus", prob = 255, param2 = 20, force_place = true}
local E = {name = "default:cactus", prob = 127, param2 = 20}

mts_save("large_cactus", {
size = {x = 5, y = 7, z = 1},
data = {
_, _, R, _, _,
_, _, R, _, _,
_, _, C, _, _,
C, C, C, C, C,
C, _, C, _, C,
E, _, C, _, E,
_, _, C, _, _,
},
})

-- Large cactus from seedling

local C = {name = "default:cactus", prob = 255, param2 = 20}
local R = {name = "default:cactus", prob = 255, param2 = 20, force_place = true}
local E = {name = "default:cactus", prob = 127, param2 = 20}

mts_save("large_cactus_from_seedling", {
size = {x = 5, y = 7, z = 1},
data = {
_, _, R, _, _,
_, _, C, _, _,
_, _, C, _, _,
C, C, C, C, C,
C, _, C, _, C,
E, _, C, _, E,
_, _, C, _, _,
},
})

[paramat]

^ That's wrong, we only need 1 schematic, the already existing one just needs changing to have 2 'R's in the trunk.
Extex101 you're welcome to try a PR if you want, but someone else can do it if you prefer.
It might also be a good idea to wait for @Ezhh 's opinion first, however i support the concept.

[TumeniNodes]

So, nothing else needs to be done?
A new seedling node is needed, yes/no? You have to have _something_ to plant.
And doesn't it need to have the growing functions added to it? (maybe not, the way it is sounding to me now)

Evidently I am incorrect about my assumptions as to what is needed...

[Extex101]

What I'm saying is that I don't know how to make a PR (I'm new to github)

And I'm not sure how to make the seedling actually grow

[Extex101]

It'd probably be better if you do it because I have no idea what would need to be done

[paramat]

Ok no problem.

TumeniNodes, yes other stuff is needed, i wrote 'we only need 1 schematic', as opposed to 2 schematics.

[TumeniNodes]

ok,

[Extex101]

OK just tell me when the PR is up

[paramat]

Hopefully you are ok with the usual CC BY-SA 3.0 for the texture?

[Extex101]

I don't even know what that is

[Extex101]

Nvm looked it up.
That's good thanks

[Extex101]

Hey @paramat I have two questions I'd like to ask:
1) What will be coming first 0.4.18 or will you go straight to 0.5.0?
2) Is there any guessed time that 0.5.0 will come out

[paramat]

That's offtopic here, best to read the forum topic about 5.0.0 in the news subforum.

[Extex101]

Well I was just wondering when I'd be seeing the seedling in MTG

[Ezhh]

It might also be a good idea to wait for @Ezhh 's opinion first

No issues with the concept as long as cacti can still be grown the current way as well. The current way makes sense for farming, whereas the type with arms would be the more natural/landscape option.

Note: growing time from a sapling should be handled carefully so that it's not quicker to get the same number of cactus nodes using this approach.

[paramat]

Ezhh i completely agree with your points.

growing time from a sapling should be handled carefully so that it's not quicker to get the same number of cactus nodes using this approach.

Very good point, will have to think about this issue. The sapling grow time may then have to be so slow as to be not worth doing.

[Extex101]

So how long does it take for one cacti to grow?
Time×11 (amount of cactus on large cactus 🌵)

[paramat]

Yeah, i'll do this anyway and calculate growth to not create an advantage.

[Extex101]

Cool can't wait!

[Extex101]

Hey is there a mod that gets a scheme and turns it into one of these

local C = {name = "default:cactus", prob = 255, param2 = 20}
local R = {name = "default:cactus", prob = 255, param2 = 20, force_place = true}
local E = {name = "default:cactus", prob = 127, param2 = 20}

mts_save("large_cactus_from_seedling", {
    size = {x = 5, y = 7, z = 1},
    data = {
        _, _, R, _, _,
        _, _, C, _, _,
        _, _, C, _, _,
        C, C, C, C, C,
        C, _, C, _, C,
        E, _, C, _, E,
        _, _, C, _, _,
    },
})

Or does it have to be done by hand?

[paramat]

Yes a mod called 'schemtools', although it displays all nodes as 'n1'. 'n2', 'n3', etc. so the table doesn't look nice.

[Extex101]

Made a PR! #2269

[paramat]

PR #2271