Minetest_game: Sync dig/place speed in creative with walking speed

[MarkuBu]

Digging/placing is a little bit slower than walking, so you have to stop sometimes.

I think it would be better to increase the speed of placing and digging in creative mode a little bit to 4 nodes per second so it does fit with walking speed

EDIT: The above is out of date, currently in master place speed is perfectly synced, dig speed is faster than walking speed.

[Fixer-007]

I also suggested this some time ago during dig time changes.

[HybridDog]

https://github.com/minetest/minetest/blob/master/minetest.conf.example#L74-L76
lf you want fast digging, you should use a tool for it.

[MarkuBu]

I don't want to have fast digging. I just want to have the same speed as I'm walking. And I don't want special tools

Just a small adjustment of the default creative digging/placing speed that you can dig/place with the same speed as you are walking, cause it's annoying if you always have to stop walking because you are faster than the nodes.

Where can I adjust the speed to test it?

[paramat]

Interesting idea. The frequency of punch might be in the engine, not sure.
Placing is much faster than walking so that can't be matched, it would be too slow, but digging frequency is already very close and slightly slower, seems ok to sync it.

[MarkuBu]

A digtime of 30 at the wieldhand seems more legit and a repeat_rightclick_time of 0.24 seems good. Needs more testing. Maybe someone can calculate the exact values

[paramat]

Oops i forgot about auto-repeat-rightclick, i was thinking about placing with rapid presses of the button.
Where in the code do we alter 'repeat_rightclick_time'?.

[paramat]

I would support a new digtime that is synced.

[paramat]

Testing in mgflat over long distances:
Digtime 26 is perfect for most nodes (level 1), slightly slow for diamond (level 3). 25 is definately too fast for level 1 nodes. So i would personally choose 26.
Placement seems to need a very slight speedup.

[MarkuBu]

Tested again. repeat_rightclick_time = 0.25 is perfect. digtime of 26 is not perfect, but I think good enough

[HybridDog]

Synchronized digging could be implemented by tracing what the player punches.
When the selected node changes and the previous one wasn't dug
and you still hold LMB and the forward key, the previous node becomes dug by executing on_dig.

[paramat]

Testing master MTE and MTG again:
Placement speed is now perfectly synced somehow.
Dig speed is synced if we slow repeated creative dig speed a little by using:
local digtime = 55 for the creative hand here:
https://github.com/minetest/minetest_game/blob/64470dc786370b9d855e77a38df362c61ccfdedc/mods/creative/init.lua#L25

Any opinions on doing this? I'm somewhat neutral.

[Ezhh]

Neutral-ish, but slightly toward not keen.

I find such shifts between creative and survival very jarring. Things like this in creative can easily make survival feel overly sluggish and unenjoyable. On the other hand, I understand some people want it to change.

But does this really address the issue? The bigger part of it is possibly placement speed?

[paramat]

? But dig speed is already very different in survival.
However, slowing dig speed slightly may be unpopular.

[Ezhh]

Yes, it's already different, which is how I know I find the switch very noticeable. Some difference is of course good (it would make no sense to have things take really long to dig in creative), but I wouldn't personally want it to the extent of everything matching walking speed.

[paramat]

It's likely that when players dig lots of nodes in creative they are not walking in a line but stationary or flying, so the benefit is small, plus slowing creative digging makes creative work slower, so closing.

[Ezhh]

The issue was to speed it up, not slow it...

[paramat]

Ah the title is out date, both dig and place have changed speeds, the new behaviour is detailed here https://github.com/minetest/minetest_game/issues/1687#issuecomment-389716769
Currently in master place speed is perfectly synced, dig speed is faster than walking speed.

[Ezhh]

Then this issue probably shouldn't have been open anyway :)

[HybridDog]

I've implemented (POC) what I have suggested before: https://github.com/HybridDog/minetest/tree/creative_unpointdig
When you walk next to a wall, point it and hold the left mouse button, the node previously pointed to automatically becomes dug if its squared distance to the current pointed node is 1, please test it.
As a POC, it works also in survival mode now, digging nodes in survival mode is slower, so you can do different tests.

l actually wanted to show a video, but sendvid didn't convert for several days now http://sendvid.com/92vwytb9

[paramat]

That would be overkill complexity for something not much needed.