I have not seen the project in a while and have not contributed to it. I was confused about different tools and workflow this project uses:
setup.py commandsMakefiletoxWhat do I suggest:
Contributing.md, since it does not contain any helpful information. What should be there? A step by step instruction how to do things. How to install dependencies? How to test your code? How to upload it to pypi?@sobolevn I think that tox is overhead because we already use Travis CI which doing same things and even more.
About the second point: I'll updated file asap.
@lk-geimfari But tox can run tests on several environments. It's very useful for a developer to final testing before push changes.
@duckyou I agree with you. But if we are creating the new branch for every new feature then push is not a problem I think. The code which works on Python 3.5 likely will work on Python 3.6.
We can vote what will be better if you want.
My opinion:
Pros: Yes, it useful on some machines where does not installed both versions of Python.
Cons: It's duplicate functionality of Travis CI.
@sobolevn Your few words, please.
@lk-geimfari Okay, you're right. It's unnecessary tool with travis and appveyor.
+1 for removing tox. It serves well when we need to test both py2 and py3, but it is not so important when dealing with only two very similar versions of python3.
Most helpful comment
+1 for removing
tox. It serves well when we need to test bothpy2andpy3, but it is not so important when dealing with only two very similar versions ofpython3.