Mimesis: Generic providers do not work

Created on 9 Aug 2017  路  5Comments  路  Source: lk-geimfari/mimesis

It's always return data in English. Looks like someone created wrong PR, Travis CI passed it and i merge this PR.

I found issue. It's returns providers without locale:

https://github.com/lk-geimfari/mimesis/blob/99dfd8275bd212ea2651afb95d843818ec81c15d/mimesis/providers/generic.py#L46

@Valerievich we need to fix it and your help will very handy.

bug

All 5 comments

Regression test will also be very nice.

I'll try to fix it today.

@Valerievich Thank you!

I can't understand how to fix this issue by new PL if my previous PL #200 isn't merged yet. All changes in my fork master branch.
All I did to fix this issue is:

return attribute(self.locale)

I checked all 'locales' through Generic(). It works well.

@Valerievich I have merged your PR. Thank you!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

faheel picture faheel  路  4Comments

lk-geimfari picture lk-geimfari  路  3Comments

4kpt picture 4kpt  路  7Comments

jjgriff93 picture jjgriff93  路  5Comments

sobolevn picture sobolevn  路  6Comments