Microsoft-ui-xaml: Update RadialGradientBrush.GradientOriginOffset to GradientOrign and default to .5, .5

Created on 27 Mar 2020  路  6Comments  路  Source: microsoft/microsoft-ui-xaml

We decided in the spec review to rename RadialGradientBrsh.GradientOrginOffset to GradientOrign to match what WPF does currently. We also want to move the starting point to top left and make the default .5,.5

area-RadialGradientBrush team-Controls
Source
picture ranjeshj

Most helpful comment

I would like to take this issue.

picture chingucoding on 27 Mar 2020
👍2

All 6 comments

I would like to take this issue.

chingucoding picture chingucoding on 27 Mar 2020
👍2

@ranjeshj doesn't WPF call the property GradientOrigin?

I'm a bit worried about the migration cost for folks coming from WPF, Silverlight, and the Windows Community Toolkit to the WinUI version with so many differences in property names and values.

michael-hawker picture michael-hawker on 28 Mar 2020
👍1

@ranjeshj doesn't WPF call the property GradientOrigin?

I'm a bit worried about the migration cost for folks coming from WPF, Silverlight, and the Windows Community Toolkit to the WinUI version with so many differences in property names and values.

Yes.. This PR is trying to make us match WPF naming.

ranjeshj picture ranjeshj on 28 Mar 2020

But the WPF's name is GradientOrigin, while in your comment you said GradientOffset. So should we rename it to GradientOrigin then?

chingucoding picture chingucoding on 28 Mar 2020

Sorry. I had the title correct and the description wrong. Yes it should match WPF.

ranjeshj picture ranjeshj on 28 Mar 2020
👍1

Thanks for clarification. PR is up to date now.

chingucoding picture chingucoding on 28 Mar 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ocalvo picture ocalvo  路  3Comments
MuziburRahman picture MuziburRahman  路  3Comments
YuliKl picture YuliKl  路  3Comments
Gavin-Williams picture Gavin-Williams  路  3Comments
widersky picture widersky  路  3Comments