Microsoft-ui-xaml: Settings does not display indicator with PaneDisplayMode = Top

[mdtauk]

Describe the bug

Steps to reproduce the bug

• Open XAML Controls Gallery (WinUI 3 Alpha) and navigate to the NavigationView example page
• Scroll down to the _NavigationView with PaneDisplayMode set to Top_ and tap the settings item

Expected behavior
Navigating to Settings should display the selected indicator as the other navigation links do.

Screenshots

_Settings selected_

_Menu Item1 selected_

Version Info
WinUI 3 Alpha

[chingucoding]

This issue is also present in WinUI 2(.3)

[robloo]

Funny, but I just noticed this a few hours ago myself.

Also present in Microsoft.UI.Xaml 2.2.190917002

[jevansaks]

Good issue! I think this is one that I wouldn't want to try to fix until @ojhad's refactor is complete. But maybe @ojhad you can keep a list of these issues (and PRs) that we want to revisit when the NavView refactor is in?

[ad1Dima]

This can be fixed alongside with bottom pinned menu items (#375) as i do in #1497

[ojhad]

Good idea! I moved the list of issues and PRs that will need to be revisited to the ItemsRepeater move dev task

[ojhad]

Refactor is in and this can now be re-visited (as it is still an issue). Unassigning myself for now.