Micro: Syntax highlighting issue on parenthesis

[nicolasbd]

Description of the problem or steps to reproduce

Related parenthesis doesn't have the same color, for example in JS files. Sorry if this has already been reported but I didn't find anything about it.

Open a javascript file and see that some function opening and closing parenthesis doesn't have the same color

Specifications

Commit hash: a02ae3c (v1.3.3 installed from Brew)
OS: Mac OS Sierra 10.12.3
Terminal: default

[tommyshem]

Info of the fault above

line 10 in runtime/syntax/javascript.yaml is causing the problem as it is catching the bracket in the regex.

• identifier: "[A-Za-z_][A-Za-z0-9_][[:space:]][(]"

Not sure how to cure this, as I am not very good at regex.

[is73]

Try to replace regexp on line 10 with
"[A-Za-z_][A-Za-z0-9_]*[[:space:]]*"

[DanielPower]

There's a similar issue with Lua.
Matching brackets are highlighted, except if there is a string between them.

[nicolasbd]

@is73 that doesn't seem to work, I'm not sure I'm proceeding properly

here is what I did :

• installed go
• installed micro with the go get -d github.com/zyedidia/micro/cmd/micro command
• change the line in ~/go/src/github.com/zyedidia/micro/runtime/syntax/javascript.yaml according to your suggestion
• run make install
• run ~/go/bin/micro some/file.js
• see no change in parenthesis highlighting

[tommyshem]

You need to use make with build-all and install or install-all to build the runtime files to see the changes.
e.g
make build-all
make install
or
make install-all
does all the above with one command.

[zyedidia]

You can also use make runtime to just build the runtime (this will make sure all changes to any files in runtime will be in the new build) and then make install to build.

[nicolasbd]

ok thanks ! it works !
I could make a PR but this is @is73 work so I don't want to steal any credit on this, maybe @zyedidia could just add it to its code ?

[is73]

It was an accident so make some PR :)

[nicolasbd]

I would also like to add the .es[5678]? extension support, so should I make two different PRs for the same file ?

[zyedidia]

You can go ahead and do both in one PR if that's easier.

[is73]

I would like to solve this in my newlisp sources to view matching paren arghhh :)
(((())))

[nicolasbd]

Here you go : https://github.com/zyedidia/micro/pull/868

Thanks for your help guys

However, I'm not sure how to apply this to lua files @DanielPower

[zyedidia]

Using regular expressions for syntax highlighting makes finding matching braces very hard or impossible. But we've fixed the javascript parentheses with a sort of workaround :). See #868.