MessageKit v2.0.0 fails to lint during cartage build

[Drusy]

• What version of MessageKit are you using?
  Tag 2.0.0

• What version of iOS are you running on?
  xcodebuild -version
  Xcode 10.2
  Build version 10E125
  carthage version
  0.33.0
  swiftlint version
  0.31.0

• Is the issue you're experiencing reproducable in the example app?
  carthage update --use-submodules --cache-builds --platform iOS

Build fails due to swiftlint errors, here are some examples:

Linting 'MessageReusableView.swift' (36/49)
/Carthage/Checkouts/MessageKit/Sources/Controllers/MessagesViewController+Menu.swift:28:1: error: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)
/Carthage/Checkouts/MessageKit/Sources/Controllers/MessagesViewController+Menu.swift:28:1: error: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly. (explicit_top_level_acl)

Linting 'CGRect+Extensions.swift' (25/49)
/Carthage/Checkouts/MessageKit/Sources/Extensions/UIEdgeInsets+Extensions.swift:27:1: error: Explicit ACL Violation: All declarations should specify Access Control Level keywords explicitly. (explicit_acl)

[nathantannar4]

1027

_{Sent with GitHawk}

[nathantannar4]

Is it fixed in the beta release?

_{Sent with GitHawk}

[Drusy]

Thanks for the PR mention, haven't seen that

2.0.0 beta fails with explicit_top_level_acl

* Checking out MessageKit at "2.0.0-beta.1"
* Checking out MessageInputBar at "0.4.0"

2.0.0 fails with explicit_top_level_acl

* Checking out MessageInputBar at "0.4.0"
* Checking out MessageKit at "2.0.0"

3.0.0 beta fails with explicit_top_level_acl

* Checking out MessageKit at "3.0.0-beta-swift4-2"
* Checking out InputBarAccessoryView at "4.2.1"

[nathantannar4]

I think you should put /Carthage in your ignore for Swiftlint for now. I use Cocoapods so sorry for not catching this. But in any case I don't think you should worry about lintint frameworks in your project

_{Sent with GitHawk}

[Drusy]

Carthage of course is in the excluded section of .swiftlint in my project. The problem occurs when building the project itself using carthage update. It's using the .swiftlint of the MessageKit project at the specified tag. My solution at the moment if to disable swiftlint from my current shell, by removing it from the PATH for example.

[fvvliet]

Same problem here as described by @Drusy

[nathantannar4]

Ok, I will fix this ASAP!

_{Sent with GitHawk}

[nathantannar4]

@Drusy should be fixed on the development branch now

[chansen22]

I still hit lint issues when pointing to development when building with Carthage.

It might be easier to skip running the lint phase during Carthage builds over trying to fix the lint issues people might be running into. In my project, my lint build phase looks like:

if [ -z "$CARTHAGE" ]
then
    swift run swiftlint --path .. --strict --quiet
fi

If $CARTHAGE isn't set, we run swiftlint, otherwise we skip it.

https://github.com/instacart/Nantes/blob/master/Nantes/Nantes.xcodeproj/project.pbxproj#L217