Meshery: [UI] Enable sub-links for settings sub-tabs
Description
Right now the URL of the subtabs in settings are distinguished by /settings#name_of_tab which is cause of many bugs right now.
Expected Behavior
Have a anchor sub-URL for each tab like settings/name_of_tab.
kushthedude
All 9 comments
Oooh, @Nikhil-Ladha... Calling @Nikhil-Ladha... 馃槃
leecalcote
on 18 Jun 2020
Here I am @leecalcote 馃憖.
Nikhil-Ladha
on 18 Jun 2020
Will look into it, over the weekend 馃槈.
Nikhil-Ladha
on 18 Jun 2020
Please @Nikhil-Ladha !
kushthedude
on 18 Jun 2020
Do we anticipate this issue to be address simultaneously or is its root cause distinct? https://github.com/layer5io/meshery/issues/273
leecalcote
on 20 Jun 2020
Related to #967
leecalcote
on 20 Jun 2020
Do we anticipate this issue to be address simultaneously or is its root cause distinct? #273
Not sure, will have to check.
Nikhil-Ladha
on 20 Jun 2020
If I may ask @kushthedude , what is the issue with the current anchor? Because the '#name_of_tab' makes sense here, considering these are subparts within a page if we use '/name_of_tab' that indicates a new page adding in the route.
Nikhil-Ladha
on 20 Jun 2020
If I am correct, the issue that you are saying are two of them:
On submitting the preferences in the performance tab the page reloads back to the environment tab rather than staying on the same one.
On initial rendering of the settings page, the path is just settings, rather it should be having the '#environment' sub link added to it.
Are these the issues you are talking about?
Nikhil-Ladha
on 20 Jun 2020
Related issues
Aisuko
路
4Comments
leecalcote
路
3Comments
MukulMaheshwari
路
4Comments
leecalcote
路
4Comments
chandrashritii
路
3Comments
Most helpful comment
Will look into it, over the weekend 馃槈.