Meshery: Decommission Meshery bash script

Created on 13 Nov 2019  路  9Comments  路  Source: layer5io/meshery

Current Behavior
The recently displaced meshery bash script currently sits in this repo's root folder under the name "meshery.old". Now that mesheryctl has displaced this script. The time has come to delete this file.

Desired Behavior
mesheryctl should perform all of its current functions with accuracy, with an acceptable user experience and on each of the three supported OSes:

Linux

  • [x] (@anandrkskd)
  • [ ] (@jsedano)

MacOS

  • [x] (@leecalcote)
  • [ ] (@jsedeano)

Windows

  • [x] (@nunix)
  • [ ] (@jsedano)

(@jesuslerma, you may wish to jump in here as well)

After each of the three checkboxes have been marked, please delete the "meshery.old" file from this repo with a PR.

componenmesheryctl kinchore

Most helpful comment

mesheryctl functions with accuracy, with an acceptable user experience on Linux system.

All 9 comments

Hey @leecalcote can I take this one? @jesuslerma will guide me around

That would be fantastic, @jsedano. Yes, please.

soo 馃槃 overall it's working great and only few small glitches remain (here is the list I found so far):

  1. the make command in Mesheryctl directory outputs a "non-Windows" name at the end. An extra: mv mesheryctl mesheryctl.exe is needed
  1. the mesheryctl status has just a \n in the timestamp line:
    time="2019-11-13T21:24:44+01:00" level=info msg="Meshery containers status . . .\n"

everything else really worked as intended:

  1. mesheryctl status now displays a nice looking table
    image
  1. the default browser opens on the correct page (no more login when connected already once 猸愶笍 )

  2. start/stop/cleanup/status work as intended

great work team 猸愶笍

Here is a short overview of the meshery bash script and exercise to validate that the same functionality and user experience is upheld in mesheryctl as we finalize the removal of meshery bash script. https://youtu.be/LMJD3HpLb8k

@nunix excellent work. :) The two issues that you've uncovered are worthy of having GitHub issues opened in order to track a fix for them. Will you kindly open these two issues?

Hi @leecalcote

here are the issues (I keep them here just for a centralised overview):

  1. Mesheryctl make issue: #494
  2. Mesheryctl status issue: #495

@nunix thank you. 馃憤

mesheryctl functions with accuracy, with an acceptable user experience on Linux system.

Given the tests complete here, I think we can call this issue safely completed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

leecalcote picture leecalcote  路  4Comments

leecalcote picture leecalcote  路  4Comments

MukulMaheshwari picture MukulMaheshwari  路  4Comments

sakomws picture sakomws  路  4Comments

leecalcote picture leecalcote  路  3Comments