Meshcentral: Device's "Plugins" tab should not be visible if no plugins want to display something in it

Created on 2 Dec 2019  路  6Comments  路  Source: Ylianst/MeshCentral

Not all plugins have an interface that you access from the interface of a single device. If you don't have any plugins that want to show something in the "Plugins" page of an individual device, the tab should be hidden from the devices menu.

image
image
In these images, I don't even have any actual plugins enabled at all (I just have the plugin system enabled but haven't downloaded any plugins), so the Plugin tab will definitely not have any content (yet) and should be hidden until a plugin actually puts something there.

bug

Most helpful comment

Excellent! Nice and simple fix, I like it. I will have a published version with this tomorrow.

All 6 comments

This is one for @ryanblenis. I agree, that tab should not show unless there is a use for it.

Submitted PR (#700) to address this.

Excellent! Nice and simple fix, I like it. I will have a published version with this tomorrow.

I'm surprised at how small the changes necessary to implement this were. Thanks for getting to this so quick!

ACK! There might be an issue with it. Will post comments on #700.

I can verify that 0.4.5-g still shows the Plugins tab when needed, but no longer shows it when no plugins use it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

vish84 picture vish84  路  3Comments

coolwormgit picture coolwormgit  路  3Comments

M1CK431 picture M1CK431  路  3Comments

guerby picture guerby  路  3Comments

MailYouLater picture MailYouLater  路  3Comments