Flowchart symbols convention specifies that flowchart Terminators (start and stop points) should have completely round end-caps. Mermaid should support such a shape.
I propose either modifying the (foo) shape to have a completely round end-cap (stroke-linecap:round) as there is no use for slightly-rounded corners in the Flowchart symbols convention, or perhaps to have a new shape ([foo]), (_foo_), or [(foo)] that has this feature.
Flowchart symbols reference:
https://www.rff.com/flowchart_shapes.php
https://www.smartdraw.com/flowchart/flowchart-symbols.htm
https://www.lucidchart.com/pages/flowchart-symbols-meaning-explained
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
A bit of activity for the stalebot.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you are still interested in it, and it is still relevant, you can comment or remove the label to revive it.
A bit of activity for the stalebot.
I approve. This should not be too difficult and is good first issue. However, think thoughly about a intuitive syntax. The proposed syntax needs some work:
([foo]), (_foo_), or [(foo)]
In PlantUML state diagrams en markers are denote with [*]. Maybe (* Text *)?
In PlantUML state diagrams en markers are denote with [*]. Maybe
(* Text *)?
Sure, that looks fine.
Using (* Text *) would cause a minor change in behaviour though, because it can be used to produce the node text "* Text *" (which works in the live editor). Should we stick to it anyway or rather use another syntax?
@GDFaber You are correct. I just checked the live editor and ([ Foo ]) does not have this problem. It also looks like the element produced, so is very fitting for Mermaid's intuitive behaviour.
Use ([ Foo ]) syntax.
This seems to be a good opportunity to shake hands with the mermaid flowcharts code, so I'd like to give this one a try.
Great, looking forward for your PR.
@GDFaber How are things going? Let me know if you are stuck. I would be glad to assist either by chat or call.
Hi @ksnv, I had no time to start with this until now, but I'll get to it tomorrow night and give it a try. I will let you know how it gets along. Thanks for offering, I will surely let you know via Slack if I run into problems.
That was fun :) I think it works properly, but I'll fill in the tests first and hand in my PR tomorrow night.
Done, my PR is at #1130.
Most helpful comment
This seems to be a good opportunity to shake hands with the mermaid flowcharts code, so I'd like to give this one a try.