Mentorship-backend: Feature : Remove expiry as a response in refresh and login endpoints.

[epicadk]

Is your feature request related to a problem? Please describe.

The access_expiry and refresh_expiry aren't fields that are required on the front end as they can be accessed by decoding the token.

Describe the solution you'd like

Remove them as responses from the refresh and login endpoints.

Additional context

They are not being used in the android app as of now.

[b-thebest]

Hello sir,
Could I take up this issue. I have experience of working with REST APIs and would like to start contributing using this issue.
Thank you

[epicadk]

Hello sir,
Could I take up this issue. I have experience of working with REST APIs and would like to start contributing using this issue.
Thank you

Hello @b-thebest , welcome to the organisation. This issue still needs to be approved by @isabelcosta .You can try pinging her on zulip In the mean time you can start working on issue that have a label status available . Goodluck : )

[b-thebest]

@epicadk I don't use Zulip and also don't have idea about that software. How can I reach her

[epicadk]

@b-thebest You can use the website for zulip as well. It is mentioned in the contact section of the readme. https://github.com/anitab-org/mentorship-backend#contact. If you still can't sign up you can wait till she responds here but it may take a little while longer.

[b-thebest]

@epicadk Private message is not allowed in Zulip for organization. I have mailed to [email protected]

[isabelcosta]

@b-thebest regarding our projects, the best way to reach out to us in on Zulip or tag us on GitHub (in my case: @isabelcosta). Talking about project development is supposed to happen in our community in the open (public) :) So that everyone can benefit from the questions you have and the answers you get. So feel free to post on the #mentorship-system stream on Zulip and reach out to the wider community. You can learn more about why private messaging is disabled in our FAQ. Email communication is mostly for sensitive matters (e.g.: violation of code of conduct of community members)

Here's our zulip: https://anitab-org.zulipchat.com/ :)

[isabelcosta]

@epicadk about this issue 🤔 I agree. so this data can be taken from the token right? Also, these fields are not yet being used by any frontend right? Will make available then

[epicadk]

@epicadk about this issue 🤔 I agree. so this data can be taken from the token right?

Yep , it can .

[isabelcosta]

Ok, will assign the issue to @b-thebest then :)

[epicadk]

Sorry accidentally closed it. I'm still getting use to GitHub mobile 😅

[b-thebest]

Thank you for assignment and kind information about reaching anitab
contributors.
From next time onwards I will be reaching out only through Zulip.

On Thu, Feb 25, 2021, 1:20 AM Aditya Kurkure [e-mail]
wrote:

Sorry accidentally closed it. I'm still getting use to GitHub mobile 😅

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/anitab-org/mentorship-backend/issues/1009#issuecomment-785330249,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ6VVH3EKVJWCQD4VLM3MKDTAVKANANCNFSM4X5VGOXQ
.