Mentorship-backend: Search users based on both the username and name
Is your feature request related to a problem? Please describe.
Currently, the search function finds the mentor/mentee based on Name. Sometimes, users are remembered by their username instead of their name. e.g. @Techno-Disaster :D
Describe the solution you'd like
Add a feature such that the users can be searched even by their username.
Describe alternatives you've considered
NA
Additional context
Refer this comment for more details.
PrashanthPuneriya
All 22 comments
Hi all 馃憢 . I was hoping to take this issue if it hasn't been claimed yet. Thanks!
brpowell
on 26 Aug 2020
Hey @PrashanthPuneriya I want to work on this issue as a part of OSH.. Please assign me
kritikaparmar-programmer
on 2 Sep 2020
Sure @kritikaparmar-programmer! Since, this is a feature request it needs approval from other contributors as well :)
@Techno-Disaster @isabelcosta @SanketDG @vj-codes Shall we proceed with this feature? As a reminder, earlier #644 issue was raised where most of the members confused the search functionality btw username and Name
PrashanthPuneriya
on 2 Sep 2020
@PrashanthPuneriya I would say we shall proceed!
vj-codes
on 2 Sep 2020
@PrashanthPuneriya Looks fine by me, it's just that it should be explicity clear in the documentation that it searches by two fields.
SanketDG
on 2 Sep 2020
@PrashanthPuneriya I want to work on this issue.I am eagerly waiting to contribute to an issue.
codesankalp
on 3 Sep 2020
Are you still available to work on this issue @kritikaparmar-programmer?
PrashanthPuneriya
on 4 Sep 2020
@PrashanthPuneriya I want to work on this issue.
codesankalp
on 4 Sep 2020
@codesankalp You are already assigned to #747. Do you want to work on this issue or the other?
PrashanthPuneriya
on 6 Sep 2020
Yes I want to work on this issue because I want to contribute in code part also.
If it is possible then assign me this issue otherwise I will try to complete that issue first and then move on to this issue.
@PrashanthPuneriya
codesankalp
on 6 Sep 2020
I am more than happy to assign you this issue after you create a PR to #747 @codesankalp :) If I assign this issue right now then it means that you will be reserving this issue and others won't be able to take up this issue. I hope you understand.
PrashanthPuneriya
on 6 Sep 2020
Yes I will fix that issue soon.
And start working on this issue soon.
Thanks.
codesankalp
on 6 Sep 2020
Is it available? I would like to work over this.
aditya2499
on 6 Sep 2020
If this is availablei will want to work on this
abhinav72610
on 8 Sep 2020
Are you available to work on this issue @codesankalp ?
PrashanthPuneriya
on 8 Sep 2020
Yes I am available, I fixed the previous issue 馃檪. You can check my pull request for that issue @PrashanthPuneriya .
You can assign me this issue.
codesankalp
on 8 Sep 2020
Assigning you @codesankalp! Happy coding :)
PrashanthPuneriya
on 8 Sep 2020
@PrashanthPuneriya Can you explain me more about this issue?
For example :- where to change the code?
codesankalp
on 8 Sep 2020
For example :- where to change the code?
You need to find that on your own @codesankalp. The starting point would be to find the code for Searching by Names.
PrashanthPuneriya
on 9 Sep 2020
Any progress @codesankalp ?
PrashanthPuneriya
on 10 Sep 2020
Working currently.
codesankalp
on 10 Sep 2020
@PrashanthPuneriya @SanketDG
Please Review this pull request.
codesankalp
on 10 Sep 2020
Related issues
PrashanthPuneriya
路
23Comments
isabelcosta
路
25Comments
faznan3nazer
路
24Comments
anna4j
路
24Comments
epicadk
路
27Comments