Mentorship-backend: Feature/bug: Decreasing the expiry time for access tokens.

[epicadk]

Is your feature request related to a problem? Please describe.

The access tokens have an expiry set to one week.

Describe the solution you'd like

Reduce the time to somewhere around 10 mins.

Additional context

This will ensure that even in the case where an access token is compromised it may be used only for a short period of time before it expires.

[devkapilbansal]

@epicadk probably expiry time is increased here only for testing purpose.

[epicadk]

@epicadk probably expiry time is increased here only for testing purpose.

I spoke to @isabelcosta and that's not the case.

[marianayap]

@isabelcosta @epicadk Hello! is someone working in this bug?

[devkapilbansal]

@marianayap consider asking it on zulip

[isabelcosta]

Ok, so thank you @epicadk and @vj-codes for your input at the Mentorship System sync up session! I now understand why this is an issue :) I will make it available then.

[isabelcosta]

@marianayap no one is working on this and this was now validated, do you still want to work on this?

[epicadk]

@marianayap no one is working on this and this was now validated, do you still want to work on this?

I think we can also add first timers only.

[Debanitrkl]

@epicadk could I work on this issue

[devkapilbansal]

@Debanitrkl you already made a pull request. As this issue is first timers only we can't assign this issue to you. However you can look for other issues.

[kartikeysaran]

I would like to work on this issue

[epicadk]

@kartikeysaran just to make sure. Is this your first contribution on this repository?

[kartikeysaran]

Not made any contributions yet in this repo

[devkapilbansal]

@kartikeysaran assigning you. 👍

[epicadk]

@kartikeysaran any updates here?

[kartikeysaran]

@kartikeysaran any updates here?
Sorry, was busy with other issues will work on this

[b-thebest]

@isabelcosta Can I work on this issue?

[kartikeysaran]

@isabelcosta Can I work on this issue?

I am busy with other issues you can work on this ! 🍻 @b-thebest

[devkapilbansal]

@isabelcosta Can I work on this issue?

Sure @b-thebest assigning you 👍

[b-thebest]

Do we need to limit expiry time of refresh token also ?

[epicadk]

Do we need to limit expiry time of refresh token also ?

No.

[epicadk]

Unassigning @b-thebest as this is marked first timers only.

[devkapilbansal]

Unassigning @b-thebest as this is marked first timers only.

Ohh, I didn't noticed that he already made a PR. Thanks for this @epicadk

[b-thebest]

Okay, no Worries, I will try to contribute other issues.

Thanks

On Tue, Mar 2, 2021, 6:03 PM Kapil Bansal [e-mail] wrote:

Unassigning @b-thebest https://github.com/b-thebest as this is marked
first timers only.

Ohh, I didn't noticed that he already made a PR. Thanks for this @epicadk
https://github.com/epicadk

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/anitab-org/mentorship-backend/issues/933#issuecomment-788875875,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ6VVH7MP6GPCYWKNAGDB6DTBTLIDANCNFSM4UHSLNZQ
.

[HeroicHitesh]

@epicadk @isabelcosta @devkapilbansal I would like to work on this

[epicadk]

@epicadk @isabelcosta @devkapilbansal I would like to work on this

Would this be your first contribution to this repository?

[HeroicHitesh]

Yes @epicadk

[epicadk]

Yes @epicadk

Assigning you. Happy coding : ).