Mentorship-backend: Tests: Cover all tests in task_comments.py

Created on 28 Jan 2021  路  13Comments  路  Source: anitab-org/mentorship-backend

Description

Some tests are missing in app/apidao/task_comments.py` file. Cover those to ensure any new change will not break existing changes.

Test Cases

The test cases that should be cover are:-

  • Task comment does not exist

https://github.com/anitab-org/mentorship-backend/blob/2917a910ab34dd5b6f800e4eac08e8fa5ba3fa0f/app/api/dao/task_comment.py#L210

Definition of Done

  • [ ] At least one test case tested.
  • [ ] Approval by 1 mentor.

Estimation

2 hours

Quality Assurance First Timers Only Testing

All 13 comments

@isabelcosta please label this issue. Also, it would be better if this issue is made first-timers-only :thinking:

Sounds good @devkapilbansal ! Thank you for thinking of first timers only issues 馃檶 馃挴

I would Like to work on this issue

Hey @devkapilbansal could I take up this issue.

Assigning you @GenRok1729
Happy coding !
@ashwinijha6 you cannot be assigned as this a first timers only issue :)

Assigning you @GenRok1729
Happy coding !
@ashwinijha6 you cannot be assigned as this a first timers only issue :)

ok @vj-codes

@GenRok1729 are you working on this??

@GenRok1729 hey any updates?

@vj-codes may be @GenRok1729 is not interested in this anymore. You should make this issue available again

Thank you @devkapilbansal @vj-codes for helping to triage this issue 馃檶馃従 You are soooo helpful 馃挴

Hi! I would like to work on this issue

Sure @PratibhaShrivastav assigning you

Hi @devkapilbansal, looks like the tests for Task comment does not exist are already present. I have added tests for Unaccepted stale relation and created a PR

Was this page helpful?
0 / 5 - 0 ratings

Related issues

isabelcosta picture isabelcosta  路  47Comments

PrashanthPuneriya picture PrashanthPuneriya  路  22Comments

paritoshsinghrahar picture paritoshsinghrahar  路  25Comments

PrashanthPuneriya picture PrashanthPuneriya  路  45Comments

isabelcosta picture isabelcosta  路  22Comments