Mentorship-backend: Use HTTPStatus instead of hard-coded values in tests/users

[tichnas]

Description

As a developer,
I need to avoid using hard-coded values wherever possible,
so that I can make code more readable and scalable.

Acceptance Criteria

Update [Required]

• [ ] Use HTTPStatus instead of hard-coded response status codes (like in the API) in tests/users
  ## Definition of Done
• [ ] All of the required items are completed.
• [ ] Approval by 1 mentor.

Estimation

2 hours

[tichnas]

@isabelcosta Please review/accept this issue. Thanks

[isabelcosta]

@tichnas could you please follow one of the issue templates provided https://github.com/anitab-org/mentorship-backend/tree/develop/.github/ISSUE_TEMPLATE?
I would recommend the user-story one.

[tichnas]

@isabelcosta Sorry for the inconvenience, I was confused between which template to use.
I've updated the description, can you please check it once again? Thanks

[sankha555]

@isabelcosta @tichnas can I please work on this issue? I can make a patch replacing all the hardcoded error codes with their corresponding HTTPStatus.response values if you could please assign it to me. Thanks!

[tichnas]

Hi @sankha555, thanks for your interest in the issue. I think this issue is simple, so why not keep it as the first-time issue to help newcomers get started? What do you suggest @isabelcosta?

[isabelcosta]

@tichnas this could be done in small PRs to avoid enormous PRs. So we could do this issue about one of the tests folders. For example, one issue could be about doing this for tests/tasks folder, and another issue for tests/users.

Could you make this issue about one of the folders please (by editing title and description)? Then If you can feel free to create the other issues or ask ion Zulip and other people can also do that (no need to be all you 😅 ). With that, we could make some only for first timers and other available to anyone 🤔 you are right that this would be nice for newcomers for sure.

What do you think @tichnas @vj-codes ?

[vj-codes]

@isabelcosta yes I agree :)
@tichnas please spilt this issue with either tasks or users subpart and let us know if you are availableto create the other similarly or not

[vj-codes]

@tichnas hey since there was no update , the issues for other folder are created , can you please edit the description of this issue to test/users folder ?
Thank you for creating the issue :)

[tichnas]

@vj-codes Sorry, I got very busy in the last week and could not take out time.

[aakankshaagr]

@vj-codes Can I take this issue?

[vj-codes]

Assigning you @aakankshaagr
Happy documenting!

[vj-codes]

@aakankshaagr any updates?

[aakankshaagr]

@vj-codes Sorry, I got very busy in the last week due to health issues and couldn't take out time. I am almost done. I will submit it by tomorrow for sure

[vj-codes]

@aakankshaagr hey no problem , just remember to update your progress after every 3 days if it's taking long:)

[aakankshaagr]

I can see these changes on my local server.
@vj-codes @tichnas I think this has worked correctly. Shall I submit PR if this is correct??
changes in POST/login (Login [user)

[vj-codes]

@aakankshaagr you can create a PR , that'll be the best way to review instead of creating a new thread in comments !

[aakankshaagr]

There is an error in tests\mentorship_relation\test_dao_creation.py which I got while running python -m unittest discover tests command.
I don't know why tests are failing and I don't know how to solve that. @vj-codes can you please guide me how to solve this problem?

[aakankshaagr]

I don't know how but all tests are passed now and I guess even that error in tests\mentorship_relation\test_dao_creation.py isn't there now.