Mentorship-backend: Replace {request_id} with {relation_id} in the Swagger UI and its related parameters

Created on 16 Aug 2020  路  14Comments  路  Source: anitab-org/mentorship-backend

Describe the bug
After a relationship has been formed between mentor and mentee, whenever a task is either created, edited, deleted or listed the Swagger UI should display the relationship between them as {relation_id} instead of {request_id}.

Expected behavior
{relation_id} should be displayed instead of {request_id}

Screenshots
image

Additional context
In addition to the Swagger UI the function parameters and its corresponding variable names needs to be modified.

User Interface Available Bug

Most helpful comment

@vj-codes @PrashanthPuneriya I think its a valid change :) Yes, it will require some big changes, but not complex ones :) Whoever takes this, can ask for help, this does not seem to change logic, just naming variables. Makes sense?

All 14 comments

@isabelcosta Can you have a look at this?
I believe that it'll require a huge change in files of resources, dao, and tests
cc: @PrashanthPuneriya

@vj-codes @PrashanthPuneriya I think its a valid change :) Yes, it will require some big changes, but not complex ones :) Whoever takes this, can ask for help, this does not seem to change logic, just naming variables. Makes sense?

I would like to work on this . Can you assign me this issue?

Assigning you @gitpurva
Happy coding!

hi i would like to work on this can i

@gitpurva it's been 5 days and no update from your side , thus unassigning you from this issue.

Assigning you @vaibhavarora102
Happy coding!

@vj-codes I have already sent a PR solving the issue and it has passed all the unit test cases also. The PR is under review.

@gitpurva sorry my bad , you haven't linked this issue in fixes part of your PR , show it didn't show up here .
Assigning you back 馃帀

@vj-codes Sorry about that. I did not know about the fixing part:(

@gitpurva
If you are not able to link then you can unassign you from this issue.
and i will make a linked pull request.
@PrashanthPuneriya you can assign me this issue.

It's been a long i.e. 18days and the pull request is not linked.
That's why i want to work on this issue.

Not linking the PR doesn't mean that the work hasn't been done. @gitpurva has almost completed the work. I was busy with my exams so I had forgotten this issue and I apologize for that @codesankalp :)

No problem @PrashanthPuneriya . I commented because the assignee didn't respond since 18 days. :smile:

Was this page helpful?
0 / 5 - 0 ratings