Mentorship-backend: Stop exposing expiry timestamp

Created on 18 Jul 2020  路  7Comments  路  Source: anitab-org/mentorship-backend

Description

As a developer,
I need to deprecate expiry timestamp,
so that I can remove misleading information fro API definition.

I confirmed that the expiry field is not being used

Mocks

image

Acceptance Criteria

Update [Required]

  • [ ] Remoove references to expiry timestamp field from POST /login

Definition of Done

  • [ ] All of the required items are completed.
  • [x] Approval by 1 mentor.

Estimation

2 hours

Coding Maintenance

Most helpful comment

Okay I will try to solve this issue ! Thanks for suggesting @isabelcosta

All 7 comments

@divyanshugit want to try this one? It's about deprecating a field being returned on Login API

Okay I will try to solve this issue ! Thanks for suggesting @isabelcosta

@divyanshugit are you working on this issue? Do you need any help?

@isabelcosta Do I need to remove the expiry field or modify the expiry field from mentorship-backend/app/messages.py / ?

Remove it @divyanshugit , so it does not get returned anymore :)

@isabelcosta I have removed the expiry field from message.py .But the run failed. Do I need to remove all the lines related to expiry field from every file available on the repo ?

@isabelcosta I have removed the expiry field from message.py .But the run failed. Do I need to remove all the lines related to expiry field from every file available on the repo ?

@divyanshugit yes :)

Was this page helpful?
0 / 5 - 0 ratings