Mentorship-backend: Fix: refactor HTTP error codes POST /mentorship_relation/{request_id}/task/{task_id}/comment

Created on 4 Jun 2020  路  3Comments  路  Source: anitab-org/mentorship-backend

Description

As a GSoC student,
I need the correct HTTP error response code to be returned accordingly by Mentorship System API in relation to POST /mentorship_relation/{request_id}/task/{task_id}/comment,
so that I can represent the error message accordingly to both Mentorship System and Bridge In Tech users.

Mocks

NA

Acceptance Criteria

Update [Required]

  • [ ] 201: Created needs to be returned instead of 200:OK if the process is successful
  • [ ] 403: Forbidden needs to be returned instead of 400: Bad Request if it has unaccepted state relation or the relation is not created by the user.

Enhancement to Update [Optional]

NA

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

1 hour

Coding Bug

Most helpful comment

I would like to work on this issue

All 3 comments

I would like to work on this issue

@gaurivn hows the PR going?

I'm on it, will send a PR soon.

Was this page helpful?
0 / 5 - 0 ratings