Mentorship-backend: Fix: refactor HTTP error codes GET /mentorship_relation/{request_id}/task/{task_id}/comments

Created on 4 Jun 2020  路  8Comments  路  Source: anitab-org/mentorship-backend

Description

As a GSoC student,
I need the correct HTTP error response code to be returned accordingly by Mentorship System API in relation to GET /mentorship_relation/{request_id}/task/{task_id}/comments,
so that I can represent the error message accordingly to both Mentorship System and Bridge In Tech users.

Mocks

NA

Acceptance Criteria

Update [Required]

  • [ ] 403: Forbidden needs to be returned instead of 400: Bad Request if it has unaccepted state relation

Enhancement to Update [Optional]

NA

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

1 hour

Coding Bug

All 8 comments

Hi @mtreacy002 - I am interested, can you assign this to me :-)

I'd be glad to if I have authority to assign you (unfortunately I don't). But, I'll pass this on to @anitab-org/coding-team and @anitab-org/bridgeintech-maintainers . Can anyone in the team please assign this issue to @Ritika5901234? Thanks, heaps.

Thanks @meenakshi-dhanani and @mtreacy002 !

@Ritika5901234 Hey how's the PR work going?

@vj-codes - thanks for commenting, I missed to push changes and raise PR here earlier.

Can I take up this issue

Assigning you @b-thebest
Happy coding!

@vj-codes @mtreacy002 Could you please review my PR

Was this page helpful?
0 / 5 - 0 ratings