Mentorship-backend: Bug: POST Task Comment API doesn't works for some tasks

[yugantarjain]

Describe the bug

The API to POST a task comment returns Internal Server Error (500) for some tasks and works as it should for some other.

Old Theory (most probably wrong):
This seems to be an issue with the hosting of the API on the server rather than the API itself. It has been observed that the API works perfectly when tested on a local server, and is only giving Internal Server Error on our server https://mentorship-backend-temp.herokuapp.com .

To Reproduce

Steps to reproduce the behavior:

1. Go to https://mentorship-backend-temp.herokuapp.com
2. Click on POST a new task comment under Mentorship Relations API
3. Click on Try it Out.
4. Enter valid token and ids.
5. Execute and see the error (on server). Also, the error isn't there when tested on local server.

Expected behavior
The API should work and post a new task comment. For a genuine error, the proper error message should be returned.

Screenshots

Desktop (please complete the following information):

• OS: [macOS]
• Browser [Safari]
• Version [13.1.1]

[isabelcosta]

Thank you @yugantarjain I just checked the logs, and I was able to see this:

[isabelcosta]

I noticed in this line of code that this feature does not seem to be implemented correctly. That is my first impression. So the task_id is not the same as task_list_id. I think this s a bug, so I will make this available for people to work on.

Line: https://github.com/anitab-org/mentorship-backend/blob/2f21124a7394e486f2432defcd039d9bb8c0f4a1/app/database/models/task_comment.py#L25

[yugantarjain]

I noticed in this line of code that this feature does not seem to be implemented correctly. That is my first impression. So the task_id is not the same as task_list_id. I think this s a bug, so I will make this available for people to work on.

Line:

https://github.com/anitab-org/mentorship-backend/blob/2f21124a7394e486f2432defcd039d9bb8c0f4a1/app/database/models/task_comment.py#L25

Okay, thanks a lot for exploring the problem so swiftly! I'll try to test a little more on the local server and see if this causes any issues.

[bipul-jha]

Is the bug still open? Can I take this issue? Thanks.

[yugantarjain]

Is the bug still open? Can I take this issue? Thanks.

Hi @bipul-jha , thanks a lot for your interest in working on this issue!

I've done some additional research on this issue and have found that the API inconsistently works for only some tasks and fails for others. Hence, it most probably is a bug in the API only and not its hosting as earlier believed.

The points that @isabelcosta have raised in the above comments shall be useful in diagnosing and fixing the problem.

Let's wait for someone to assign this issue to you. Thanks!

[bipul-jha]

Sure @yugantarjain, will start working once assigned.

[isabelcosta]

@bipul-jha thank you for your interest in contributing to this project and following our guidelines! I just assigned you, so feel free to start looking into this.

It's important to note that @yugantarjain is no longer facing the bug, as far as I know, but I think that is just luck, for example using a user that does not expose this bug.

[yugantarjain]

We are facing this bug 😅 The API works for some tasks and doesn't for some others.

[isabelcosta]

@bipul-jha are you still working on this issue?

[bipul-jha]

Hey @isabelcosta, I am not able to get much time. Maybe I can come back some other time, and pick some task. For now, I am unassigning myself. Sorry for that.

[DartingMelody]

Hi @isabelcosta, Can I work on this. I was trying it out, can you help me in getting the access token for checking the result of this API.

[yugantarjain]

Hi @isabelcosta, Can I work on this. I was trying it out, can you help me in getting the access token for checking the result of this API.

Hi @DartingMelody! Thanks a lot for your interest in working on this issue!
To get the access token, you'll have to sign-up as a new user (and then verify your email) and login. On login, the API response will contain the access token.
Thanks again!

[isabelcosta]

@DartingMelody This documentation I wrote can also help you understand login:

• https://github.com/anitab-org/mentorship-backend/blob/develop/docs/user_authentication.md
• https://github.com/anitab-org/mentorship-backend/wiki/Log-in-using-Swagger-UI

I will assign this to you :) Let us know if you have more doubts.

[vj-codes]

@DartingMelody unassigning you due to inactivity

[saikirankv]

@vj-codes @isabelcosta I'm interested to take this issue, but I have a few queries regarding this.

as per comments, I came to know that it's not reproducible in local. How to check the logs? Is there any test env for checking this issue?

[vermastuti]

Hi, I would like to take up this issue if not assigned already.