Mentorship-backend: Add tests for Assigning a new admin API

[isabelcosta]

Description

As a developer,
I need have tests for assigning a new admin feature,
so that I can have the feature coverage and make sure it's working properly.

Have a test function for each of this cases:

• Assigning a user which is already an admin -> should receive a message saying that the user is already an admin
• Assigning a user which is not an admin -> should become an admin
• Assigning a user as an admin, when the current user is not an admin -> should receive an error message
• Assigning a non-existent user -> should receive error message
• Try using the API without sending authentication token -> should receive an error message

You can test your tests running:

python -m unittest discover tests

Acceptance Criteria

Update [Required]

• [ ] Create a test file, on tests/admin folder, with test cases for assigning a new admin API (you can follow this test case example https://github.com/systers/mentorship-backend/blob/develop/tests/users/test_api_list_users.py)

Definition of Done

• [ ] All of the required items are completed.
• [x] Approval by 1 mentor.

Estimation

4 hours

[isabelcosta]

@systers/maintainers-mentorship-backend need approval on this if you agree.

[sys-bot]

The author of the issue cannot approve the issue.

[KritiRav]

Can I claim this issue?

[isabelcosta]

@KritiRav yes you can :) tell us if you need help or get stuck

[isabelcosta]

@KritiRav any updates on this?

[BadduCoder]

@isabelcosta Please have a look at the code. If there is something missing, I will add on to that.

[BadduCoder]

@isabelcosta I just found out that issue #142 is also solved by my PR. so adding that.

[vermastuti]

Is this issue resolved?

[isabelcosta]

@vermastuti no its not, I see not tests in admin folder calling the Admin Assignment API. Tests of this kind usually begin with test_api_*.
Are you interested in working on this?

[vermastuti]

Yeah, I would like to work on this.

[isabelcosta]

@vermastuti I am sorry for the delay in the response. I just assign it to you, if you are not interested in the issue, let me know and I'll make it available again :)

[devkapilbansal]

@vermastuti Are you still interested in this issue??

[vj-codes]

Making the issue available due to inactivty.

[b-thebest]

Anyone working on this ?

[epicadk]

Anyone working on this ?

Nope it is marked as status available would you like to work on it?

[b-thebest]

Okay, please assign this issue to me @epicadk

[vj-codes]

@b-thebest hey any updates?

[b-thebest]

Sory for being late, I am working on this issue

On Tue, Mar 23, 2021, 1:21 AM Vaishnavi Joshi @.*>
wrote:

@b-thebest https://github.com/b-thebest hey any updates?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/anitab-org/mentorship-backend/issues/141#issuecomment-804348775,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ6VVH3IFZSK3QTOM34XPI3TE6NSLANCNFSM4FSKNVVA
.