Mentorship-backend: Bug: Dev server GET all users 503 error response

[mtreacy002]

When I tried to get list of all users on the dev server, it returned 503 error response 'Service Unavailable'. This doesn't happen when the same request is done on the local server.

To Reproduce

Steps to reproduce the behavior:

1. Go to dev server Swagger UI https://mentorship-backend-temp.herokuapp.com.
2. Login and get the access token.
3. Scroll down to GET users and use the token to get users list.
4. See error

Expected behavior
This request should return list of users.

Screenshots
error response on dev server:

the expected behaviour (screenshot from local server response)

Desktop (please complete the following information):

• OS: IOS Mojave 10.14.6
• Browser: Safari
• Version??

Additional context
This issue was discussed in Zulip here.

This issue also might be related to issue #279 with PR#541

[mtreacy002]

@isabelcosta, I'm not sure if just anyone can work on this issue, because the code change needs to be tested on dev server (which means after the code change got merged). Will you be ok if this PR is assigned to you? Alternatively, we can assume the issue is related to #279 which hopefully after the PR is approved and merged, the issue should disappear 😉

[isabelcosta]

@mtreacy002 No problem in getting this assigned to me. However, I am pretty sure that this is solved with some pagination, it's not scalable to fetch every user (e.g.: 200+) in the database whenever a client (e.g.: Android app, Swagger UI) calls that endpoint.

For reference, here are the Heroku logs I shared on Zulip:

I am suggesting that this gets solved with pagination, also because I tested, with a search query to reduce the results and got a correct response. So it seems this can be the server taking to long to fetch every entry in the User table. So once PR #541 regarding Pagination is merged, this might get mitigated a bit. I will label the PR as of High priority.

[Abdelaty]

Any updates here? Because this issue is a blocker for [Members Search does not work anitab-org/mentorship-android#633] (https://github.com/anitab-org/mentorship-android/pull/633)

[surbhigoel191]

I would like to work on this issue! @isabelcosta @mtreacy002

[isabelcosta]

@surbhigoel191 have you confirmed that this bug is a bug. I seem to remember this as being a bug solved by https://github.com/anitab-org/mentorship-backend/pull/541. i may be confusing, but if you could check first if this is still valid that would be great :)

[surbhigoel191]

@surbhigoel191 have you confirmed that this bug is a bug. I seem to remember this as being a bug solved by #541. i may be confusing, but if you could check first if this is still valid that would be great :)

Sorry for the late reply.
Yes, you are right, it has been resolved. We can close this issue now.

[isabelcosta]

Closing this issue, since it's not reproducible.