Mentorship-android: Bottom navigation moves up

[devansh-299]

Describe the bug
In Members fragment, bottom navigation bar moves up when soft-keyboard is shown while searching for members. The bottom navigation bar shouldn't have moved up.

To Reproduce
Steps to reproduce the behavior:

1. Go to Members Fragment
2. Click on Click on search bar on the top
3. Observe that bottom navigation bar moves up

Expected behavior
The bottom navigation bar shouldn't have moved up when keyboad is shown

Screenshots

Smartphone (please complete the following information):

• Xiaomi PocoF1
• Android 10
• Version: 29

[vj-codes]

@devansh-299 what solution would you like to say for this issue?If the bottom nav bar doesnt move up it will be hidden behind the keyboard as an alternative should the search open a new page?

[devansh-299]

@devansh-299 what solution would you like to say for this issue?If the bottom nav bar doesnt move up it will be hidden behind the keyboard as an alternative should the search open a new page?

@vj-codes I guess bottom nav being hidden should be no problem. I have never seen bottom navigation getting moved up because of soft keyboard in any application

[vj-codes]

@devansh-299 same issue occurs when a user tries to enter password in login screen , the contents are shifted upward.
Can you add it in this issue or shall I create another one?

[devansh-299]

@devansh-299 same issue occurs when a user tries to enter password in login screen , the contents are shifted upward.
Can you add it in this issue or shall I create another one?

@vj-codes I cannot reproduce the issue you pointed out. Also, in my opinion, shifting of elements other than bottom navigation bar shouldn't be an issue

[devptyagi]

Anyone working on this issue?

[MariamKotob]

Describe the bug
In Members fragment, bottom navigation bar moves up when soft-keyboard is shown while searching for members. The bottom navigation bar shouldn't have moved up.

To Reproduce
Steps to reproduce the behavior:

1. Go to Members Fragment
2. Click on Click on search bar on the top
3. Observe that bottom navigation bar moves up

Expected behavior
The bottom navigation bar shouldn't have moved up when keyboad is shown

Screenshots

Smartphone (please complete the following information):

• Xiaomi PocoF1
• Android 10
• Version: 29

@devansh-299 you're right you have a point here. The navigation bar being shifted like that isn't so user friendly but I also don't think hiding it behind the keyboard would be the best solution actually most applications open a new popup for the search functionality. I'm not sure if that's the recommended way but that' what I've observed. you can check the search in google play app for example.

[MariamKotob]

@devansh-299 same issue occurs when a user tries to enter password in login screen , the contents are shifted upward.
Can you add it in this issue or shall I create another one?

As Devansh said I can't reproduce this either. Are you sure that it's still an issue in the current version? If yes please upload a GIF so we can understand.

[MariamKotob]

Anyone working on this issue?

Up to now, it's still in discussion. Let me check if @devansh-299 wants to work on it first. Else I'll assign it to you. Please, be patient.

[MariamKotob]

@devansh-299 you're right you have a point here. The navigation bar being shifted like that isn't so user friendly but I also don't think hiding it behind the keyboard would be the best solution actually most applications open a new popup for the search functionality. I'm not sure if that's the recommended way but that' what I've observed. you can check the search in google play app for example.

For more clarification; what I meant is this emty view appears after tapping search bar on the contacts app.

[devptyagi]

@MariamKotob Okay sure! No Problem. :)

[devansh-299]

@MariamKotob Okay sure! No Problem. :)

@devptyagi you can work on this issue

[devansh-299]

Describe the bug
In Members fragment, bottom navigation bar moves up when soft-keyboard is shown while searching for members. The bottom navigation bar shouldn't have moved up.
To Reproduce
Steps to reproduce the behavior:

1. Go to Members Fragment
2. Click on Click on search bar on the top
3. Observe that bottom navigation bar moves up

Expected behavior
The bottom navigation bar shouldn't have moved up when keyboad is shown
Screenshots

Smartphone (please complete the following information):

• Xiaomi PocoF1
• Android 10
• Version: 29

@devansh-299 you're right you have a point here. The navigation bar being shifted like that isn't so user friendly but I also don't think hiding it behind the keyboard would be the best solution actually most applications open a new popup for the search functionality. I'm not sure if that's the recommended way but that' what I've observed. you can check the search in google play app for example.

@MariamKotob yeah that's also a good approach, but I think we should discuss this with the community before going with this approach

[devansh-299]

@devansh-299 you're right you have a point here. The navigation bar being shifted like that isn't so user friendly but I also don't think hiding it behind the keyboard would be the best solution actually most applications open a new popup for the search functionality. I'm not sure if that's the recommended way but that' what I've observed. you can check the search in google play app for example.

For more clarification; what I meant is this emty view appears after tapping search bar on the contacts app.

Thanks

[MariamKotob]

@MariamKotob yeah that's also a good approach, but I think we should discuss this with the community before going with this approach

Sure let's move this discussion to Zulip.

[vj-codes]

I would prefer a new empty view @MariamKotob @devansh-299

[HaripriyaB]

Even I do prefer a separate view for search feature.

[devansh-299]

It seems that the new window approach is the one to proceed with. So should I modify the existing issue or open a new one and close this?

[MariamKotob]

It seems that the new window approach is the one to proceed with. So should I modify the existing issue or open a new one and close this?

I guess it would be too vague for others if you modify this issue. I'd prefer you to open a new one.

[devansh-299]

Closing this as #732 addresses the updated problem