Mentorship-android: Automatically add email in the Feedback form

[Priyansh-Kedia]

Description

The current feedback form in the mentorship application asks for email id. This way users can also put email id of someone else and submit a feedback.
The email id should be self populated with the email id of the user logged in currently.

Mocks

Before

After

[Priyansh-Kedia]

@m-murad @isabelcosta
May I work on this issue?

[isabelcosta]

@Priyansh-Kedia I would argue another thing. Is this field even needed? Thinking about when this becomes implemented on the backend, we only need to send the id of the user in the request body right? My suggestion would be to take this field from the form. What do you think @Priyansh-Kedia ?
If you agree i am ok with you working on this :) Just let me know so I can assign this to you

[Priyansh-Kedia]

@Priyansh-Kedia I would argue another thing. Is this field even needed? Thinking about when this becomes implemented on the backend, we only need to send the id of the user in the request body right? My suggestion would be to take this field from the form. What do you think @Priyansh-Kedia ?
If you agree i am ok with you working on this :) Just let me know so I can assign this to you

@isabelcosta
I think this field should be shown to the user so that the user is well informed that they will be receiving an email on the particular email id.
For example, I myself have 2 different email id. It might be possible that I do not remember the email id I used to login to the mentorship app. So it would be helpful if I am being shown the email id that I will be receiving mail on.

I hope that I wasn't vague in the explanation.
Thanks

[Priyansh-Kedia]

@isabelcosta
I was going through the code for FeedBack activity and found out that the backend code for feedback has been left blank currently.
Can this be raised as another issue by someone from the backend?

[isabelcosta]

@isabelcosta
I was going through the code for FeedBack activity and found out that the backend code for feedback has been left blank currently.
Can this be raised as another issue by someone from the backend?

@Priyansh-Kedia do you mean creating an issue on this repo about integrating backend API?
You can do it, but until there is the backend implementation of it, this is blocked.
Feel free to create the issue here :)

[Priyansh-Kedia]

@isabelcosta
Implementing this on the backend has to be done by someone from the backend only

Till then, may I populate the email field with the email with which the user logged in (The current issue)?

[isabelcosta]

I think this field should be shown to the user so that the user is well informed that they will be receiving an email on the particular email id.
For example, I myself have 2 different email id. It might be possible that I do not remember the email id I used to login to the mentorship app. So it would be helpful if I am being shown the email id that I will be receiving mail on.

Interesting 🤔 I would accept two solutions:

• autofill the field instead of just filling the hint. Then if the email is correct the user does not have to change it.
• removing that field and assume the email the user register for the system is the one. Remember that in this way, in the backend we don't need to store an additional email, we don't need to deal with that data at all.

I will post this on Zulip for people to provide their input as well :)

[Priyansh-Kedia]

I think this field should be shown to the user so that the user is well informed that they will be receiving an email on the particular email id.
For example, I myself have 2 different email id. It might be possible that I do not remember the email id I used to login to the mentorship app. So it would be helpful if I am being shown the email id that I will be receiving mail on.

Interesting I would accept two solutions:

• autofill the field instead of just filling the hint. Then if the email is correct the user does not have to change it.
• removing that field and assume the email the user register for the system is the one. Remember that in this way, in the backend we don't need to store an additional email, we don't need to deal with that data at all.

I will post this on Zulip for people to provide their input as well :)

Sure
According to me the first option should be implemented due to the reason mentioned.
But please ask for reviews on Zulip and tell me how it has to be implemented.

Thanks

[isabelcosta]

@Priyansh-Kedia in some time we may get some more feedback and see how it goes.

[jotharman]

@isabelcosta i am interested in working on the backend part of this. Should I create an issue there?

[isabelcosta]

@jotharman I think that the issue is already created there. Can you please check that before creating a new issue? Also if the issue exists can you ask to work on it, in case it is not assigned to anyone yet. Then I can assign this to you :)

[jotharman]

@isabelcosta okay sure :)

[isabelcosta]

I have another thought about this, regarding it email field being pre filled and disabled or not show there at all. I posted this on Zulip today.

Do we need the email? We could show it as a disabled field, my thing is about having access to another email. How can we verify the email is from this actual user? Couldn't I go there and put into the app, my friend's email without their permission?! When you sign up to the app you are accepting certain terms, and us holding your email in our databases is part of the terms and conditions, but if we allow the user to put another email without verifying and all, that does not seem correct 🤔

[Priyansh-Kedia]

I have another thought about this, regarding it email field being pre filled and disabled or not show there at all. I posted this on Zulip today.

Do we need the email? We could show it as a disabled field, my thing is about having access to another email. How can we verify the email is from this actual user? Couldn't I go there and put into the app, my friend's email without their permission?! When you sign up to the app you are accepting certain terms, and us holding your email in our databases is part of the terms and conditions, but if we allow the user to put another email without verifying and all, that does not seem correct thinking

Yeah, others might suggest something even better.
I will wait for your review.

[bartekpacia]

Because of no new responses I'll assume this is open :)

[vj-codes]

Are you still working on this issue? @Priyansh-Kedia

[Priyansh-Kedia]

@vj-codes I am waiting for an approval and the idea on how to be doing it.
I was also hoping for approval on changing the architecture of the app
If I get approval on that, then you can take this up.

Thanks

[vj-codes]

Cool! I asked so i could add a label to the issue :) @Priyansh-Kedia

[Techno-Disaster]

wow the feedback form works on android client?
good to know will bring it up in todays flutter session :)

[Priyansh-Kedia]

@isabelcosta Any updates?

[anna4j]

@isabelcosta What is to be done about the email field in the Feedback form?

[isabelcosta]

@anna4j, for now, we should just have the email ID of the current user, and have the field disabled. This is a temporary solution until we have a redesign of the screens :)

[maharishi1]

can I work on it? please assign me.

[anna4j]

can I work on it? please assign me.

Absolutely go ahead