Mentorship-android: Last item of recycler view hiding behind bottom navbar

[naveennvrgup]

Describe the bug
In relation and members screens the last member of recycler view is always hiding behind the bottom navbar. This abstracts the view of the interests and briefs of that member item. The problem can be solved by proper layout. (In the screenshot we cant view sophia fully and its the last item. No more bottom scroll possible)

To Reproduce
Visit Relation and Members screens.

Expected behavior
The last item in the recycler view should be fully visible.

Screenshots

Smartphone:

• Device: Pixel 2
• OS: Android 9 Pie

[Priyansh-Kedia]

@isabelcosta May I work on this issue?

[Kavya-24]

May I work on this issue?

[naveennvrgup]

sure go ahead @Priyansh-Kedia

[Priyansh-Kedia]

sure go ahead @Priyansh-Kedia

Thanks @naveennvrgup

@m-murad Could you please approve this issue?

[AminullahTajMuhammad]

@Priyansh-Kedia I want to working on this issue.

[Priyansh-Kedia]

@AminullahTajMuhammad
I am actually waiting for approval on this issue.

[m-murad]

This issue is there with all fragments in the MainActivity. This should be fixed for the activity and not for the fragments specifically.

@Priyansh-Kedia you can go ahead and send a fix for this.
@Kavya-24 @AminullahTajMuhammad sorry but Priyansh was here first.

[Priyansh-Kedia]

Thank you @m-murad
Here is the PR for the same https://github.com/anitab-org/mentorship-android/pull/653#issue-390257390
Please check.

[Kavya-24]

@m-murad #641 is of profile fragment , which is not wrapped in a RecyclerView. Not corrected by the code change of #653
Attached a pr #654

[Priyansh-Kedia]

@m-murad #641 is of profile fragment , which is not wrapped in a RecyclerView. Not corrected by the code change of #653
Attached a pr #654

@Kavya-24 These are two different issue, thank you for pointing this out anyway.
I think this issue and the profile fragment issue have to be raised and resolved separately.
I have tried to fix the recyclerview issue.
Thanks again for your input.

[Kavya-24]

@Priyansh-Kedia Thank You too for the RecyclerView Issue.

@m-murad #641 is of profile fragment , which is not wrapped in a RecyclerView. Not corrected by the code change of #653
Attached a pr #654

@Kavya-24 These are two different issue, thank you for pointing this out anyway.
I think this issue and the profile fragment issue have to be raised and resolved separately.
I have tried to fix the recyclerview issue.
Thanks again for your input.

[isabelcosta]

I approve of this issue! Thank you @naveennvrgup for taking the initiative to "assign" the issue to the first contributor, @Priyansh-Kedia , that requested to work on this :) I agree with implementing this. Also thank you all for reviewing and approving the issue :)

[isabelcosta]

Opening up this again, as the PR that was open could not be tested. @Priyansh-Kedia you did great work that can be continued by someone else or sent over on a PR by you. Either way let us know if you are still interested in this PR.

For anyone who wants to take this on, this PR https://github.com/anitab-org/mentorship-android/pull/653 completed the issue :)

[Priyansh-Kedia]

Sure @isabelcosta
I would send a new PR for the same

[Priyansh-Kedia]

@isabelcosta
This is the new PR
Please review