Mentorship-android: Put all strings from FeedbackActivity on strings.xml

Created on 24 Feb 2020  路  15Comments  路  Source: anitab-org/mentorship-android

Description

FeedbackActivity has a lot of hardcoded strings in the code. These strings should be put into strings.xml because it is a good practice and to enable future internationalization features on this text.

Acceptance Criteria

Update [Required]

  • [ ] Move all hardcoded strings from FeedbackActivity to strings.xml

Definition of Done

  • [ ] All of the required items are completed.
  • [ ] Approval by 1 mentor.

Estimation

1 hour

Coding First Timers Only Enhancement

All 15 comments

Hello @isabelcosta please can I work on this?

I wanted to do this but I am unable to find the feedback activity! Can you help?

Hello @pratikghule i already commented on the issue. I鈥檓 waiting for @isabelcosta approval to work on it. I think she has to finish merging PRs from GCI. Thanks

yes I have come to know that all these GCI19 issues are done and only the finish work is remain... after that they'll close it! Welcome.

@Rita-Okonkwo you can work on this once we merge the work from GCI, which is almost done ;)
thank you for your interest @Rita-Okonkwo @pratikghule

yayyy! thank you so much @isabelcosta . Please how will we know when the work from GCI has been merged?

yayyy! thank you so much @isabelcosta . Please how will we know when the work from GCI has been merged?

Yes, sure! I or @anitab-org/admins will let the community know, we are almost there ;)

Thanks once again @isabelcosta

thanks @isabelcosta

May I work on this issue?

Sorry @Rita-Okonkwo I forgot to get back to this issue. Since you contributed already and this is first timers only issue, can you look for other issues, please?

@pratikghule are you still interested in this issue? If yes, let me know so I can assign this to you

Hi @isabelcosta yes please I will look for other issues so first timers can have a chance to contribute

Sorry @Rita-Okonkwo I forgot to get back to this issue. Since you contributed already and this is first timers only issue, can you look for other issues, please?

@pratikghule are you still interested in this issue? If yes, let me know so I can assign this to you

Yes I would love to do it!

i will assign it to your then :) @pratikghule

Hi @isabelcosta I have made all the changes as told and this one would work well.

Was this page helpful?
0 / 5 - 0 ratings