Is your feature request related to a problem? Please describe.
Right now, the only way to login in into the app is through the login/password combo for the account the user created. But it would be better if the application also provided other alternatives to log in using, for eg google, facebook, systers slack data, systers mailing list data etc.
this is a feature request from app documentation: [Required] Login with Systers data (or other profiles such as google or facebook, Systers slack data, Systers mailing list data)
Describe the solution you'd like
Adding buttons to the login page that redirect to respective login portals, for eg. a sign in with google button would redirect to google's login web page portal etc.
@vj-codes @aditmehta9 I would like to work on this issue
Assigning you.Happy coding! @rahulshah456
@vj-codes @aditmehta9 I would like to work on this issue
@rahulshah456 can you please describe your approach for this issue? As I think this issue needs to be discussed and approved before working on it
@devansh-299 I am thinking of making a new social login/logout endpoint in mentorship backend which will handle all third party auth like Google, Facebook & Twitter. There are some flask libraries that can be used to achieve this behavior.
And for this feature implementation, I will soon create a new issue in the mentorship-backend with my overall approach and that can be discussed in the Zulip for any improvements.
@devansh-299 I am thinking of making a new social login/logout endpoint in mentorship backend which will handle all third party auth like Google, Facebook & Twitter. There are some flask libraries that can be used to achieve this behavior.
And for this feature implementation, I will soon create a new issue in the mentorship-backend with my overall approach and that can be discussed in the Zulip for any improvements.
I think before proceeding, you should validate this issue with any of the project admins as it's going to involve a lot of work at both back-end and at user-facing applications
Do we need to describe how the solution can be implemented??and if yes where to describe it, in the docs or in the PR??
@Aditiwebd even I have the same question. To implement this feature, some major changes in the backend are required. So, some more clarification should be provided about how we are supposed to submit a PR.
@siddheshkothadi @Aditiwebd yes there will be backend changes too and there is an issue up on backend repo for the same.
However, this issue is more about researching ways for social logins and not about coding and making social login work.
There might be multiple ways to implement this feature , some longer some easier.So if in your research anything backend related comes up , you can mention something like data read/taken from backend repo
Your research should be done in a markdown file and added to docs/spikes folder adding flowcharts , diagrams while explaining can also be done here.
Does this clear your doubt?If not do update
yes,thankyou for the explanation.I would like to work on it,Please assign it to me.
Thanks @vj-codes : )
That clears my doubt!
I would like to work on this issue
Assigning you both @siddheshkothadi @Aditiwebd
Happy researching!
Both of your ideas may/may not be same , but make sure the PRs are not exactly same .Also if it's taking long , do update your progress after every 3 days :)
Thanks @vj-codes !
ohk sure..thanku
Update : Currently, I'am researching about various ways to use Google OAuth in android and some flask libraries for the same. I'll need some more time to figure out other login methods like Facebook, etc.
What are the login methods we have to provide.Are google and facebook fine??
@Aditiwebd yeah sure